Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maps Tiles related code cleanup #7418

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Maps Tiles related code cleanup #7418

merged 4 commits into from
Jul 17, 2023

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Jul 16, 2023 •
edited
Loading

To make things easier for the Editor changes.

  • move 2 functions out of the Tiles::Maps class as they don't belong there
  • function and variable renaming for easier code support

relates to #6845

@ihhub
Maps Tiles related code cleanup
dc7411c 
To make things easier for the Editor changes.
@ihhub ihhub added the improvement New feature, request or improvement label Jul 16, 2023
@ihhub ihhub added this to the 1.0.7 milestone Jul 16, 2023
@ihhub ihhub self-assigned this Jul 16, 2023
Districh-ru
Districh-ru requested changes Jul 16, 2023
View reviewed changes
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihhub, I left one suggestion. Could you check it when you have time.

@ihhub ihhub requested a review from Districh-ru July 17, 2023 14:46
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
1.1% 1.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ihhub ihhub merged commit 2563ba5 into master Jul 17, 2023
@ihhub ihhub deleted the tiles_cleanup branch July 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-derevenetz oleg-derevenetz oleg-derevenetz approved these changes

@Districh-ru Districh-ru Districh-ru approved these changes

Assignees

@ihhub ihhub

Labels
improvement New feature, request or improvement
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ihhub @oleg-derevenetz @Districh-ru