Create basic Map Editor GUI #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add BaseInterface class to begin move there methods common for game and editor interface
ihhub
requested changes
Jun 28, 2023
There was a problem hiding this comment.
Hi @Districh-ru , I left several comments in this pull request. Could you please take a look at them when you have time?
- remove default parameter from base class method; - make Editor and AdventurMap classes 'final'
|
I added @oleg-derevenetz to the list of reviewers to have architecture design opinion. |
ihhub
requested changes
Jul 3, 2023
There was a problem hiding this comment.
Hi @Districh-ru , I left few more comments in this pull request. Could you please check them when you have free time?
ihhub
approved these changes
Jul 5, 2023
oleg-derevenetz
approved these changes
Jul 5, 2023
|
@Districh-ru , huge thanks for doing these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6845
This PR adds Map Editor GUI. (Currently its functions are in development and are not implemented in this PR.)
fheroes2.2023-06-11.21-19-10-526.1.mp4