chore: switch to tinyglobby #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69e8908 to
5aff957
Compare
5aff957 to
6867ee2
Compare
|
I like the idea, but this risks a breaking change and the popularity/use/maturity of these two packages is wildly different: https://npmtrends.com/glob-vs-tinyglobby |
|
While true that glob is more popular, tinyglobby is popular enough that any bugs would quickly be discovered. If you compare tinyglobby to any other library, it's still popular on its own. tinyglobby's usage increased 50% in the past month, so it's being adopted pretty quickly. |
|
There are a couple of open issues that seem alarming. There is no rush here, so I'm inclined to give this some more time to bake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://npmgraph.js.org/?q=glob@10.4.5 - 26 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
It also supports much older versions of Node avoiding the issues in #508. Because we can upgrade to the latest version it will also dedupe better whereas users are split across multiple majors for
glob