Suppress LGTM alert for ZipSlip in PluginMonitor #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginMonitor.java
Fixed
Show fixed
Hide fixed
ZipSlip is possible only when explicitly enabled by an administrator. No need to have a static analyzer alert for this particular case.
63463c9 to
4fd11d3
Compare
| @@ -479,7 +479,9 @@ | |||
| for ( Enumeration e = zipFile.entries(); e.hasMoreElements(); ) | |||
| { | |||
| JarEntry entry = (JarEntry) e.nextElement(); | |||
| Path entryFile = dir.resolve( entry.getName() ); // ignore possibility for zipslip as this is sanitized for if property is enabled lgtm [java/zipslip] | |||
| Path entryFile = dir.resolve( entry.getName() ); /* lgtm[java/zipslip] */ | |||
Check failure
Code scanning / CodeQL
Arbitrary file write during archive extraction ("Zip Slip")
|
An additional observation: if a malicious attacker is able to upload a plugin (that might have a ZipSlip vulnerability), they are able to upload executable code. I wonder to what extend guarding against ZipSlip here actually improve security significantly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZipSlip is possible only when explicitly enabled by an administrator. No need to have a static analyzer alert for this particular case.