Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: downgrade nightly to 0.50 #4507

Merged
merged 29 commits into from
Feb 20, 2025
Merged

refactor!: downgrade nightly to 0.50 #4507

merged 29 commits into from
Feb 20, 2025

Conversation

julienrbrt
Copy link
Member

Closes: #4501

@julienrbrt julienrbrt mentioned this pull request Feb 14, 2025
Open
@julienrbrt julienrbrt marked this pull request as ready for review February 18, 2025 16:53
Pantani
Pantani reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't run chain server:
✘ json: cannot unmarshal string into Go value of type chaincmdrunner.Account

@julienrbrt
Copy link
Member Author

I can't run chain server: ✘ json: cannot unmarshal string into Go value of type chaincmdrunner.Account

Yes, you need to use Go 1.23 locally, because of #4509.
Scaffolding using Go 1.24 is broken due to the logs that outputs the sonic log library. It is pretty annoying tbh (https://github.com/bytedance/sonic/blob/51ef60549b15eb404fed30a1e2eef906847e131e/decoder/decoder_compat.go#L35).

@julienrbrt julienrbrt requested a review from Pantani February 20, 2025 01:17
Pantani
Pantani approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@julienrbrt julienrbrt merged commit ac62a79 into main Feb 20, 2025
39 of 45 checks passed
@julienrbrt julienrbrt deleted the julien/downgrade branch February 20, 2025 08:48
@julienrbrt julienrbrt mentioned this pull request Feb 20, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages component:templates type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPDATE: Downgrade nightly to v0.50
2 participants
@julienrbrt @Pantani