-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate ibc x 0.52 #4477
base: main
Are you sure you want to change the base?
Conversation
Is the app wiring still not working for IBC? |
Nope, they haven't prioritized it yet :/ -> cosmos/ibc-go#3560 |
Using cosmos/ibc-go#7882 branch until this gets merged to main. |
We have prioritized it and tried: cosmos/ibc-go#6216 But the wiring system doesn't support our structure very well, so it is iceboxed at the moment. Hopefully we can revisit this, because we obviously would prefer to have app wiring in our own test images as well to reduce maintenance. |
Merged now :) |
That'd be awesome. As you can see the wiring without IBC adopting app wiring isn't the best: https://github.com/ignite/example/blob/master/app/ibc.go#L41-L42 & https://github.com/noble-assets/noble/blob/2592437/legacy.go#L45. |
Closes: #4387