Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate ibc x 0.52 #4477

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat: integrate ibc x 0.52 #4477

wants to merge 23 commits into from

Conversation

julienrbrt
Copy link
Member

Closes: #4387

@Pantani
Copy link
Collaborator

Pantani commented Jan 23, 2025

Is the app wiring still not working for IBC?

@julienrbrt
Copy link
Member Author

Is the app wiring still not working for IBC?

Nope, they haven't prioritized it yet :/ -> cosmos/ibc-go#3560

@julienrbrt
Copy link
Member Author

Using cosmos/ibc-go#7882 branch until this gets merged to main.

@gjermundgaraba
Copy link
Contributor

Is the app wiring still not working for IBC?

Nope, they haven't prioritized it yet :/ -> cosmos/ibc-go#3560

We have prioritized it and tried: cosmos/ibc-go#6216

But the wiring system doesn't support our structure very well, so it is iceboxed at the moment. Hopefully we can revisit this, because we obviously would prefer to have app wiring in our own test images as well to reduce maintenance.

@gjermundgaraba
Copy link
Contributor

Using cosmos/ibc-go#7882 branch until this gets merged to main.

Merged now :)

@julienrbrt
Copy link
Member Author

julienrbrt commented Jan 25, 2025

Is the app wiring still not working for IBC?

Nope, they haven't prioritized it yet :/ -> cosmos/ibc-go#3560

We have prioritized it and tried: cosmos/ibc-go#6216

But the wiring system doesn't support our structure very well, so it is iceboxed at the moment. Hopefully we can revisit this, because we obviously would prefer to have app wiring in our own test images as well to reduce maintenance.

That'd be awesome. As you can see the wiring without IBC adopting app wiring isn't the best: https://github.com/ignite/example/blob/master/app/ibc.go#L41-L42 & https://github.com/noble-assets/noble/blob/2592437/legacy.go#L45.
It isn't bad, the mixed way it supported, but it isn't that intuitive. You could already, migrate your simapp to something to using runtime as well (like does ignite and noble), so sdk upgrades would be less painful in your simapp.

@julienrbrt julienrbrt marked this pull request as ready for review January 27, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPDATE: Re-Enable IBC After v0.52 Compatibility
3 participants