Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate buf config files to v2 #4452

Merged
merged 13 commits into from
Jan 24, 2025
Merged

feat: migrate buf config files to v2 #4452

merged 13 commits into from
Jan 24, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 19, 2024 •
edited
Loading

close #4166

Description

  • Bump buf version;
  • Move buf.yaml and buf.lock to the root and update to v2;
  • Search for v1 and v2 buf files;

@Pantani Pantani self-assigned this Dec 19, 2024
@github-actions github-actions bot added the type:services Service-related issues. label Dec 20, 2024
@Pantani Pantani marked this pull request as draft December 20, 2024 07:03
@Pantani
Merge remote-tracking branch 'origin/main' into feat/buf-config-v2
caa3c89 
# Conflicts:
#	go.mod
#	go.sum
#	ignite/internal/plugin/testdata/execute_fail/go.mod
#	ignite/internal/plugin/testdata/execute_ok/go.mod
#	ignite/internal/tools/gen-mig-diffs/go.mod
#	ignite/templates/app/files/go.mod.plush
@Pantani
bump buf
a043be2
@Pantani
bump mod.plush deps
6890e0f
@Pantani
fix buf yaml parse
cd357f0
@Pantani
add name to module buf yaml config
a496cf1
@Pantani Pantani marked this pull request as ready for review January 23, 2025 17:48
julienrbrt
julienrbrt reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review this tomorrow, i need to understand the v2 changes as well 😅

@Pantani Pantani requested a review from julienrbrt January 24, 2025 02:01
julienrbrt
julienrbrt approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👏🏾

@julienrbrt julienrbrt enabled auto-merge (squash) January 24, 2025 16:48
@julienrbrt julienrbrt merged commit f484480 into main Jan 24, 2025
43 of 46 checks passed
@julienrbrt julienrbrt deleted the feat/buf-config-v2 branch January 24, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPDATE: Migrate to Buf Config v2
2 participants
@Pantani @julienrbrt