Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable gci linter #4159

Merged
merged 7 commits into from
May 20, 2024
Merged

chore: enable gci linter #4159

merged 7 commits into from
May 20, 2024

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 19, 2024

  • gci

Please make sure to check the following for your PR:

  • This PR complies with the contributing guidelines.
  • Reviewed "Files changed" and left comments if necessary
  • Included relevant documentation changes.

Ignite CLI team only:

  • I have updated the Unreleased section in the changelog.md for my changes.
  • If the templates in ignite/templates/files have been changed, make
    sure that the change doesn't need to be reflected in the
    ignite/templates/files-* folders.

julienrbrt
julienrbrt previously approved these changes May 19, 2024
View reviewed changes
@faddat faddat dismissed julienrbrt’s stale review May 19, 2024 19:00

The merge-base changed after approval.

@julienrbrt julienrbrt merged commit c22073b into ignite:main May 20, 2024
48 checks passed
julienrbrt pushed a commit that referenced this pull request May 29, 2024
@faddat @julienrbrt
chore: enable gci linter (#4159)
14c9487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@faddat faddat

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faddat @julienrbrt