Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use gopkg.in/yaml.v3 instead gopkg.in/yaml.v2 #4075

Merged
merged 12 commits into from
Apr 22, 2024
Merged

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Apr 8, 2024

No description provided.

@Pantani Pantani self-assigned this Apr 8, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. type:internal component:packages labels Apr 8, 2024
@Pantani Pantani requested review from salmad3 and toschdev as code owners April 8, 2024 11:43
@julienrbrt
Copy link
Member

What's the advantage?

@Pantani
Copy link
Collaborator Author

Pantani commented Apr 10, 2024

What's the advantage?

The indentation matches with the Goland, and the v3 has some fixes not had in the v2

@Pantani
Copy link
Collaborator Author

Pantani commented Apr 10, 2024

and we can also can remove the v2 from the go mod soon, the most of package are using v3

julienrbrt
julienrbrt previously approved these changes Apr 12, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Pantani Pantani enabled auto-merge (squash) April 16, 2024 12:30
salmad3
salmad3 previously approved these changes Apr 17, 2024
@Pantani Pantani dismissed stale reviews from salmad3 and julienrbrt via 84c5218 April 18, 2024 10:06
@Pantani Pantani requested a review from salmad3 April 18, 2024 10:07
@Pantani Pantani requested a review from julienrbrt April 22, 2024 10:42
@Pantani Pantani merged commit f369490 into main Apr 22, 2024
46 checks passed
@Pantani Pantani deleted the chore/bump-yaml branch April 22, 2024 10:46
julienrbrt pushed a commit that referenced this pull request May 29, 2024
* use 	`gopkg.in/yaml.v3` instead `gopkg.in/yaml.v2`

* add changelog

* fix unit tests

* run make format

---------

Co-authored-by: Pantani <Pantani>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants