-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use gopkg.in/yaml.v3
instead gopkg.in/yaml.v2
#4075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
April 8, 2024 11:40
github-actions
bot
added
component:ci
CI/CD workflow and automated jobs.
component:configs
type:services
Service-related issues.
type:internal
component:packages
labels
Apr 8, 2024
What's the advantage? |
The indentation matches with the Goland, and the v3 has some fixes not had in the v2 |
and we can also can remove the v2 from the go mod soon, the most of package are using v3 |
julienrbrt
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
salmad3
previously approved these changes
Apr 17, 2024
julienrbrt
approved these changes
Apr 22, 2024
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* use `gopkg.in/yaml.v3` instead `gopkg.in/yaml.v2` * add changelog * fix unit tests * run make format --------- Co-authored-by: Pantani <Pantani>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:ci
CI/CD workflow and automated jobs.
component:configs
component:packages
type:internal
type:services
Service-related issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.