Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove error check after command flag get #3976

Merged
merged 3 commits into from
Feb 19, 2024
Merged

chore: remove error check after command flag get #3976

merged 3 commits into from
Feb 19, 2024

Conversation

jeronimoalbi
Copy link
Member

Checking errors is not required because flag values are initially validated on execution while setting the string values.

Closes #1101

@jeronimoalbi
chore: remove error check after command flag get
8b2bad2 
Checking errors is not required because flag values are initially
validated on execution while setting the string values.
@jeronimoalbi jeronimoalbi self-assigned this Feb 19, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Feb 19, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (82ec261) 24.78% compared to head (9a1f21f) 24.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
+ Coverage   24.78%   24.91%   +0.12%     
==========================================
  Files         296      296              
  Lines       24915    24792     -123     
==========================================
  Hits         6176     6176              
+ Misses      18172    18049     -123     
  Partials      567      567
Files Coverage Δ
ignite/cmd/chain_debug.go 0.00% <0.00%> (ø)
ignite/cmd/generate_composables.go 0.00% <0.00%> (ø)
ignite/cmd/generate_hooks.go 0.00% <0.00%> (ø)
ignite/cmd/generate_vuex.go 0.00% <0.00%> (ø)
ignite/cmd/scaffold_band.go 0.00% <0.00%> (ø)
ignite/cmd/scaffold_chain.go 0.00% <0.00%> (ø)
ignite/cmd/scaffold_map.go 0.00% <0.00%> (ø)
ignite/cmd/generate_typescript_client.go 0.00% <0.00%> (ø)
ignite/cmd/scaffold_package.go 0.00% <0.00%> (ø)
ignite/cmd/scaffold_query.go 0.00% <0.00%> (ø)
... and 3 more

julienrbrt
julienrbrt approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1101 (comment) TIL.
ACK.

@jeronimoalbi jeronimoalbi merged commit d0bf0e9 into main Feb 19, 2024
44 checks passed
@jeronimoalbi jeronimoalbi deleted the chore/remove-flag-getter-error-check branch February 19, 2024 15:40
julienrbrt pushed a commit that referenced this pull request May 29, 2024
@jeronimoalbi @julienrbrt
chore: remove error check after command flag get (#3976)
8f823fd 
* chore: remove error check after command flag get

Checking errors is not required because flag values are initially
validated on execution while setting the string values.

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd: remove error checks when reading flags
2 participants
@jeronimoalbi @julienrbrt