Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg/cache): support version prefix #3829

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Conversation

jeronimoalbi
Copy link
Member

Cache can optionally prefix keys with a version when available through the storage.

Ignite CLI version is used as key prefix for cached values to avoid potential issues when major CLI updates are released, making --clear-cache optional.

The --clear-cache can still be used to clear all cached values when necessary.

@jeronimoalbi jeronimoalbi added component:go Related to core go code. type:enh Improvement or update to existing feature(s). labels Dec 7, 2023
@jeronimoalbi jeronimoalbi self-assigned this Dec 7, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. component:packages labels Dec 7, 2023
@jeronimoalbi jeronimoalbi marked this pull request as ready for review December 7, 2023 17:27
julienrbrt
julienrbrt previously approved these changes Dec 8, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it would be great to add unit tests.
Should we as well let ignite doctor clear the ignite cache?

Pantani
Pantani previously approved these changes Dec 8, 2023
@jeronimoalbi jeronimoalbi dismissed stale reviews from Pantani and julienrbrt via b442c07 December 12, 2023 09:06
Pantani
Pantani previously approved these changes Dec 12, 2023
@Pantani Pantani requested a review from julienrbrt December 12, 2023 15:41
Pantani
Pantani previously approved these changes Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #3829 (820f378) into main (1b08ba3) will increase coverage by 0.03%.
The diff coverage is 84.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3829      +/-   ##
==========================================
+ Coverage   24.32%   24.36%   +0.03%     
==========================================
  Files         293      294       +1     
  Lines       24538    24555      +17     
==========================================
+ Hits         5970     5982      +12     
- Misses      18032    18036       +4     
- Partials      536      537       +1     
Files Coverage Δ
ignite/pkg/cache/cache.go 67.74% <100.00%> (+2.62%) ⬆️
ignite/pkg/cache/options.go 100.00% <100.00%> (ø)
ignite/services/plugin/cache.go 64.40% <100.00%> (+1.90%) ⬆️
ignite/cmd/cmd.go 5.97% <0.00%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

julienrbrt
julienrbrt previously approved these changes Dec 13, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeronimoalbi jeronimoalbi dismissed stale reviews from julienrbrt and Pantani via 820f378 December 13, 2023 10:57
@jeronimoalbi jeronimoalbi merged commit 1999c2b into main Dec 13, 2023
43 checks passed
@jeronimoalbi jeronimoalbi deleted the feat/cache-version-prefix branch December 13, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:go Related to core go code. component:packages type:enh Improvement or update to existing feature(s). type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants