-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg/cache): support version prefix #3829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but it would be great to add unit tests.
Should we as well let ignite doctor clear the ignite cache?
b442c07
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
+ Coverage 24.32% 24.36% +0.03%
==========================================
Files 293 294 +1
Lines 24538 24555 +17
==========================================
+ Hits 5970 5982 +12
- Misses 18032 18036 +4
- Partials 536 537 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
820f378
Cache can optionally prefix keys with a version when available through the storage.
Ignite CLI version is used as key prefix for cached values to avoid potential issues when major CLI updates are released, making
--clear-cache
optional.The
--clear-cache
can still be used to clear all cached values when necessary.