Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename Marshaler to Codec #3658

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

Ehsan-saradar
Copy link
Contributor

@Ehsan-saradar Ehsan-saradar commented Sep 18, 2023

Closes #3641

@Ehsan-saradar Ehsan-saradar changed the base branch from master to main September 18, 2023 06:59
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit f2600b8):

https://igntservices-docs--pr3658-feat-rename-marshale-q4zk0exp.web.app

(expires Mon, 25 Sep 2023 07:00:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@Ehsan-saradar Ehsan-saradar changed the title Implement Codec in Place of Marshaler to Align with CosmosSDK Patterns refactor: rename Marshaler to Codec Sep 18, 2023
@Ehsan-saradar Ehsan-saradar changed the title refactor: rename Marshaler to Codec feat: rename Marshaler to Codec Sep 18, 2023
@Ehsan-saradar Ehsan-saradar force-pushed the feat/rename-marshaler-to-codec branch from a0327b9 to 7e4f23a Compare September 18, 2023 08:28
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Contributor Author

@Ehsan-saradar Ehsan-saradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pantani
Please check again your review and if its ok, then we can go forward

@Pantani Pantani merged commit b0f75fa into main Sep 26, 2023
@Pantani Pantani deleted the feat/rename-marshaler-to-codec branch September 26, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Marshaler with Codec to mimic CosmosSDK patterns.
4 participants