Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: uin64 overflow fix #3610

Merged
merged 8 commits into from
Aug 10, 2023
Merged

chore: uin64 overflow fix #3610

merged 8 commits into from
Aug 10, 2023

Conversation

soring323
Copy link
Contributor

@soring323 soring323 commented Aug 2, 2023 •
edited by jeronimoalbi
Loading

cosmos faucet has overflow issue because uint64. Ethermint based chain is using decimal 18 so uint64 is not enough for them.
Instead of that. it's more reasonable to use sdk.int of cosmos types.

Closes #3609

@max-hontar
Copy link
Contributor

max-hontar commented Aug 2, 2023 •
edited
Loading

sdk.Int is deprecated so better to use sdkmath.Int
And worth to mention related issue (also yours): Fix #3609

Pantani
Pantani previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@Pantani
Copy link
Collaborator

Pantani commented Aug 3, 2023

@dedicatedDev can you please add changelog?

@soring323 soring323 force-pushed the cosmos-faucet-overflow branch from dede211 to 53e15b8 Compare August 3, 2023 22:34
@soring323
Copy link
Contributor Author

@dedicatedDev can you please add changelog?

added

jeronimoalbi
jeronimoalbi previously approved these changes Aug 8, 2023
View reviewed changes
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. component:packages labels Aug 9, 2023
@jeronimoalbi jeronimoalbi merged commit 0891ffe into ignite:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@max-hontar max-hontar Awaiting requested review from max-hontar

Assignees
No one assigned
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

faucet amount is limited.
4 participants
@soring323 @max-hontar @Pantani @jeronimoalbi