Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply auto tools migration to other commands #3524

Merged
merged 7 commits into from
Jun 5, 2023
Merged

feat: apply auto tools migration to other commands #3524

merged 7 commits into from
Jun 5, 2023

Conversation

jeronimoalbi
Copy link
Member

Resolves #3517

@jeronimoalbi jeronimoalbi added type:new To implement new feature. skip-changelog Don't check changelog for new entries component:cli-doctor Related to Ignite doctor. labels May 31, 2023
@jeronimoalbi jeronimoalbi requested review from Pantani and ilgooz May 31, 2023 11:36
@jeronimoalbi jeronimoalbi self-assigned this May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #3524 (4930b29) into main (728e82d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3524      +/-   ##
==========================================
- Coverage   23.99%   23.99%   -0.01%     
==========================================
  Files         295      295              
  Lines       23747    23756       +9     
==========================================
+ Hits         5699     5701       +2     
- Misses      17539    17547       +8     
+ Partials      509      508       -1
Impacted Files Coverage Δ
ignite/cmd/chain.go 0.00% <0.00%> (ø)
ignite/cmd/generate.go 0.00% <0.00%> (ø)
ignite/pkg/cosmosgen/install.go 82.35% <0.00%> (ø)

... and 1 file with indirect coverage changes

@jeronimoalbi jeronimoalbi requested a review from Pantani June 2, 2023 07:52
@ilgooz ilgooz merged commit 23abd9a into main Jun 5, 2023
@ilgooz ilgooz deleted the feat/extra-commands-auto-migration branch June 5, 2023 14:51
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@jeronimoalbi
feat: apply auto tools migration to other commands (ignite#3524)
615c855 
* fix: add tools file check to tools migration handler

* chore: add tools migration to generate command pre run handler

* refactor: change doctor to fix dependency tools imports

* refactor: improve doctor code structure

* refactor: unify doctor messages UI message styles

* chore: define tools file path in a single package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:cli-doctor Related to Ignite doctor. skip-changelog Don't check changelog for new entries type:new To implement new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply the auto migration to other commands
3 participants
@jeronimoalbi @Pantani @ilgooz