fix(services/chain): prevent overriding minimum-gas-prices with default value #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
previously approved these changes
Apr 4, 2023
|
Thanks for the fix @kruspy! Would you add a new Fixes sub section at the top of the |
Sure ! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3470 +/- ##
=======================================
Coverage ? 23.69%
=======================================
Files ? 300
Lines ? 23697
Branches ? 0
=======================================
Hits ? 5615
Misses ? 17577
Partials ? 505
|
|
Updated the changelog @jeronimoalbi, please excuse the delay. |
No problem! Thanks for your contribution 👍 |
jeronimoalbi
approved these changes
Apr 13, 2023
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…lt value (ignite#3470) * fix(services/chain): prevent overriding minimum-gas-prices with default value * update changelog.md --------- Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3469
Moves the default assignment of
minimum-gas-pricesbefore the config values are updated with the validator's Cosmos SDK app config.Please make sure to check the following for your PR: