Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ibc-go v6 #3369

Merged
merged 24 commits into from
Jan 9, 2023
Merged

feat: ibc-go v6 #3369

merged 24 commits into from
Jan 9, 2023

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jan 4, 2023 •
edited
Loading

Closes #3137
Closes #3387

@jeronimoalbi
Copy link
Member

@aljo242 shouldn't the ChannelKeeper interface in pkg/cosmosibckeeper be updated to match the changes to the SendPacket function? If so we should also update the SendPacket references in the templates.

@aljo242
Copy link
Contributor Author

aljo242 commented Jan 6, 2023

I'll need to remove the cosmosibckeeper dependency from new chains to get this migration to work.

tbruyelle
tbruyelle approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to upgrade my IBC knowledge to really understand what's happening here, but in the mean time, I ran the IBC tutorial with this version and everything went well.

@aljo242
Copy link
Contributor Author

aljo242 commented Jan 9, 2023

Will update any docs in #3395

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #3369 (5aa7eec) into main (f7bf449) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3369   +/-   ##
=======================================
  Coverage   23.44%   23.45%           
=======================================
  Files         298      298           
  Lines       23496    23496           
=======================================
+ Hits         5509     5511    +2     
+ Misses      17490    17489    -1     
+ Partials      497      496    -1
Impacted Files Coverage Δ
ignite/pkg/cosmosclient/consensus.go 0.00% <ø> (ø)
ignite/pkg/cosmosibckeeper/keeper.go 0.00% <ø> (ø)
ignite/services/scaffolder/module.go 0.00% <ø> (ø)
ignite/templates/module/create/ibc.go 0.00% <0.00%> (ø)
ignite/pkg/xast/xast.go 81.81% <0.00%> (+9.09%) ⬆️

@aljo242 aljo242 merged commit 321ce4f into main Jan 9, 2023
@aljo242 aljo242 deleted the feat/ibc-v6 branch January 9, 2023 16:36
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
feat: ibc-go v6 (ignite#3369)
bf363c2 
* ibc update

* templates

* docs

* changelog

* fix template go mod

* fix test

* packet api

* fix SendPacket template

* fix

* new version

* update GetChannel

* rename stub

* deprecate pkg

* update template

* fix

* refactor packet template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove cosmosibckeeper from scaffolded chains IBC-v6.0.0 support for ignite
3 participants
@aljo242 @jeronimoalbi @tbruyelle