Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow id and creator as names when scaffolding a type. #3320

Merged
merged 4 commits into from
Dec 18, 2022
Merged

fix: Allow id and creator as names when scaffolding a type. #3320

merged 4 commits into from
Dec 18, 2022

Conversation

DimitrisJim
Copy link
Contributor

should fix both #3316 and #3317

@DimitrisJim DimitrisJim changed the title Allow id and creator as names when scaffolding a type. fix: Allow id and creator as names when scaffolding a type. Dec 17, 2022
@aljo242
Copy link
Contributor

aljo242 commented Dec 17, 2022

Thank you @DimitrisJim !!

Can you please add a CHANGELOG entry?

tbruyelle
tbruyelle approved these changes Dec 18, 2022
View reviewed changes
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should have some tests in this package.

@aljo242
Copy link
Contributor

aljo242 commented Dec 18, 2022

LGTM, we should have some tests in this package.

Created issue:

#3321

@tbruyelle tbruyelle merged commit 1e622ff into ignite:main Dec 18, 2022
This was referenced Dec 19, 2022
Closed
Closed
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@DimitrisJim
fix: Allow id and creator as names when scaffolding a type. (ignite#3320
f91f357 
)

* Allow id and creator as names when scaffolding a type.

* Add changelog entry.

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@aljo242 aljo242 aljo242 approved these changes

@lumtis lumtis Awaiting requested review from lumtis

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitrisJim @aljo242 @tbruyelle