Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated actions.yml for resolving deprecation message #3244

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Dec 7, 2022

workerB

set-ouput command is being deprecated in a number of months, and we should migrate to Github's new recommend path.
Its here https://github.com/ignite/cli/actions/runs/3618877364/jobs/6099257660

Proposed solution
A workflow using save-state or set-output like the following

  run: echo "::save-state name={name}::{value}"
- name: Set output
  run: echo "::set-output name={name}::{value}"

should be updated to write to the new GITHUB_STATE and GITHUB_OUTPUT environment files:

  run: echo "{name}={value}" >> $GITHUB_STATE
- name: Set output
  run: echo "{name}={value}" >> $GITHUB_OUTPUT

Additional context
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files

@SaumyaBhushan SaumyaBhushan changed the title updated actions.yml for resolving deprecation message chore: updated actions.yml for resolving deprecation message Dec 7, 2022
@SaumyaBhushan
Copy link
Contributor Author

@tbruyelle I have made the changes regarding the actions set-output deprecation message. Please review

Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you for this @SaumyaBhushan

@aljo242 aljo242 merged commit 43d58bd into ignite:main Dec 7, 2022
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
…3244)

* updated actions.yml for resolving deprecation message

* modified:CHANGELOG.md

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants