Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed grpc_* prefix from query files in scaffolded chain #3224

Merged
merged 8 commits into from
Dec 5, 2022
Merged

fix: removed grpc_* prefix from query files in scaffolded chain #3224

merged 8 commits into from
Dec 5, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Dec 5, 2022 •
edited
Loading

workerB

fix: #3223

@SaumyaBhushan SaumyaBhushan changed the title Removed grpc_* prefix from query files in scaffolded chain fix: Removed grpc_* prefix from query files in scaffolded chain Dec 5, 2022
@tbruyelle
Copy link
Contributor

@SaumyaBhushan thank you for this contribution, can you add an entry in the changelog plz?

@SaumyaBhushan
Copy link
Contributor Author

@SaumyaBhushan thank you for this contribution, can you add an entry in the changelog plz?

Sure @tbruyelle

@SaumyaBhushan
Copy link
Contributor Author

@tbruyelle Its done. Also I see a deprecation message from the actions workflow for set-output. I have worked on this before, if you want I can update the workflow with latest syntax . You can open an issue for that . Thanks

tbruyelle
tbruyelle reviewed Dec 5, 2022
View reviewed changes
@tbruyelle
Copy link
Contributor

@tbruyelle Its done. Also I see a deprecation message from the actions workflow for set-output. I have worked on this before, if you want I can update the workflow with latest syntax . You can open an issue for that . Thanks

Where is that deprecation message ? Anyway don't hesitate to create the issue yourself if you spotted it 🙏

@SaumyaBhushan
Copy link
Contributor Author

@tbruyelle Its done. Also I see a deprecation message from the actions workflow for set-output. I have worked on this before, if you want I can update the workflow with latest syntax . You can open an issue for that . Thanks

Where is that deprecation message ? Anyway don't hesitate to create the issue yourself if you spotted it pray

Sure Thanks. Its here https://github.com/ignite/cli/actions/runs/3618877364/jobs/6099257660

@tbruyelle tbruyelle mentioned this pull request Dec 5, 2022
Merged
@tbruyelle
Copy link
Contributor

I restart the failing test, it's a flaky one because sometime the cosmos-sdk test framework uses a port reserved by the github action servers.

@jeronimoalbi
Copy link
Member

Thanks for contributing @SaumyaBhushan 👍

I think one more file need renaming too:
ignite/templates/query/files/x/{{moduleName}}/keeper/grpc_query_{{queryName}}.go.plush

@jeronimoalbi jeronimoalbi changed the title fix: Removed grpc_* prefix from query files in scaffolded chain fix: removed grpc_* prefix from query files in scaffolded chain Dec 5, 2022
@SaumyaBhushan
Copy link
Contributor Author

Thanks for contributing @SaumyaBhushan +1

I think one more file need renaming too: ignite/templates/query/files/x/{{moduleName}}/keeper/grpc_query_{{queryName}}.go.plush

Right @jeronimoalbi . Thanks for pointing it out.

@codecov
Copy link

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@dce3b10). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3224   +/-   ##
=======================================
  Coverage        ?   19.97%           
=======================================
  Files           ?      382           
  Lines           ?    30108           
  Branches        ?        0           
=======================================
  Hits            ?     6014           
  Misses          ?    23519           
  Partials        ?      575

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aljo242 aljo242 merged commit bfd8b50 into ignite:main Dec 5, 2022
@SaumyaBhushan SaumyaBhushan deleted the Issue#3223 branch December 6, 2022 04:17
aljo242 pushed a commit that referenced this pull request Dec 6, 2022
@SaumyaBhushan
fix: removed grpc_* prefix from query files in scaffolded chain (#3224)
47a2e3d 
* Removed grpc_* prefix from query files in scaffolded chain

* modified:changelog.md

* modified:changelog.md

* Removed grpc_* prefix from query files in scaffolded chain

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
aljo242 added a commit that referenced this pull request Dec 7, 2022
@albttx @fadeev
@tbruyelle @jeronimoalbi @Pantani @SaumyaBhushan @github-actions @aljo242
chore: update deps (#3241)
c9e43f0 
* vuln and math

* go-git

* go-yaml

* mockery + regen

* grpc

* chore(docs): docs v0.25.2 (latest) and nightly (#3206)

* chore(docs): docs v0.25.2 (latest) and nightly

* chore: add versionning documentation

* chore(ci): generate docs on new release

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* docs: "Hello, World!" tutorial rewrite (#3218)

* Getting started

* fix: dir name

* proto in cosmos sdk

* query wip

* finish the hello tutorial

* added a paragraph about default module

* chore: apply mdgofmt on docs

Had to re-apply the fixes I did on the docs to the `versioned_docs`
version.

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@tendermint.com>

* docs: fix path in hello tutorial (#3226)

* docs: fix path in hello tutorial

* formatting

* refactor(`config`):  organization (#3202)

* base

* base refactor

* refactor

* rename

* rename

* fix comment

* rename file

* format

* refactor base

* format

* refactor some imports

* imports refactor

* fix

* fix import

* refactor:

* changelog

* changelog

* Update ignite/services/network/networkchain/init.go

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* base -> baseconfig

* refactoring for clarity

* v12 -> v1

* fix tests

* fix integration

* fix name

* fix integration

* format

* Update ignite/cmd/cmd.go

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* imports

* LocateDefault logic

* lint fix

* refactor and test

* finish refactor

* revert

* move

* move

* rename

* fix tests

* fix test

* fix error statement for global plugins

* typo

* chainconfig

* imports

* fix imports

* address review

* testdata

* better import

* fix test

* fix

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* feat(CI): add codecov coverage (#3220)

* add codecov coverage

* create a new script file for the coverage test and put the coverage file into the .gitignore

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* feat(plugin): support plugin path with hash (#3217)

* feat(plugin): support plugin path with hash

Move the clone logic to xgit.Clone so it can be used for instance in the
`network chain publish` command. In the future it could also support
private repos.

* improve code format

* remove useless TODO

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* fix: interrupt plugin commands (#3222)

Due to the plugin architecture, the user wasn't able to interrupt a
plugin command via Ctrl+C. This is annoying if the plugin execution is
long.

By running the plugin execution in a goroutine and by listening to the
command context at the same time, we can fix that.

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* docs: added manual section to the hello tutorial (#3227)

* docs: added manual section to the hello tutorial

* fix: formatting

* fix: formatting

* ignite generate proto-go

* fix: remove grpc_ prefix

* add ignite chain serve

* fix: phrasing when new files are created

* Update docs/docs/guide/03-hello.md

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* Update docs/docs/guide/03-hello.md

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* fix: removed grpc_* prefix from query files in scaffolded chain (#3224)

* Removed grpc_* prefix from query files in scaffolded chain

* modified:changelog.md

* modified:changelog.md

* Removed grpc_* prefix from query files in scaffolded chain

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* chore: go formatting (#3232)

Co-authored-by: aljo242 <aljo242@users.noreply.github.com>

* docs(cli): update generated docs (#3207)

Co-authored-by: aljo242 <aljo242@users.noreply.github.com>
Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* chore(docs): Fix some broken links and add a link checker for the markdown files (#3219)

* Fix some broken links and add a link checker for the markdown files

* add md link checker config

* fix broken links

* remove redirect links from checker

* remove redirect links from checker

* remove duplicated config

* remove babylon blockchain link and change master to main for cosmos-sdk docs

* fix broken links

* remove sdk modules links because the redirection

* github moved links

* github moved links

* fix local links

* remove atom ide

* ignite guides

* add link checkr configs

* remove unused slash for urls

* exclude github 403 result links

* fix github link

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

Co-authored-by: Albert Le Batteux <contact@albttx.tech>
Co-authored-by: Denis Fadeev <denis@fadeev.org>
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@tendermint.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Co-authored-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aljo242 <aljo242@users.noreply.github.com>
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@SaumyaBhushan
fix: removed grpc_* prefix from query files in scaffolded chain (igni…
c8a2c73 
…te#3224)

* Removed grpc_* prefix from query files in scaffolded chain

* modified:changelog.md

* modified:changelog.md

* Removed grpc_* prefix from query files in scaffolded chain

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@albttx @fadeev
@tbruyelle @jeronimoalbi @Pantani @SaumyaBhushan @github-actions @aljo242
chore: update deps (ignite#3241)
166cbf9 
* vuln and math

* go-git

* go-yaml

* mockery + regen

* grpc

* chore(docs): docs v0.25.2 (latest) and nightly (ignite#3206)

* chore(docs): docs v0.25.2 (latest) and nightly

* chore: add versionning documentation

* chore(ci): generate docs on new release

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* docs: "Hello, World!" tutorial rewrite (ignite#3218)

* Getting started

* fix: dir name

* proto in cosmos sdk

* query wip

* finish the hello tutorial

* added a paragraph about default module

* chore: apply mdgofmt on docs

Had to re-apply the fixes I did on the docs to the `versioned_docs`
version.

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@tendermint.com>

* docs: fix path in hello tutorial (ignite#3226)

* docs: fix path in hello tutorial

* formatting

* refactor(`config`):  organization (ignite#3202)

* base

* base refactor

* refactor

* rename

* rename

* fix comment

* rename file

* format

* refactor base

* format

* refactor some imports

* imports refactor

* fix

* fix import

* refactor:

* changelog

* changelog

* Update ignite/services/network/networkchain/init.go

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* base -> baseconfig

* refactoring for clarity

* v12 -> v1

* fix tests

* fix integration

* fix name

* fix integration

* format

* Update ignite/cmd/cmd.go

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* imports

* LocateDefault logic

* lint fix

* refactor and test

* finish refactor

* revert

* move

* move

* rename

* fix tests

* fix test

* fix error statement for global plugins

* typo

* chainconfig

* imports

* fix imports

* address review

* testdata

* better import

* fix test

* fix

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* feat(CI): add codecov coverage (ignite#3220)

* add codecov coverage

* create a new script file for the coverage test and put the coverage file into the .gitignore

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* feat(plugin): support plugin path with hash (ignite#3217)

* feat(plugin): support plugin path with hash

Move the clone logic to xgit.Clone so it can be used for instance in the
`network chain publish` command. In the future it could also support
private repos.

* improve code format

* remove useless TODO

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* fix: interrupt plugin commands (ignite#3222)

Due to the plugin architecture, the user wasn't able to interrupt a
plugin command via Ctrl+C. This is annoying if the plugin execution is
long.

By running the plugin execution in a goroutine and by listening to the
command context at the same time, we can fix that.

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* docs: added manual section to the hello tutorial (ignite#3227)

* docs: added manual section to the hello tutorial

* fix: formatting

* fix: formatting

* ignite generate proto-go

* fix: remove grpc_ prefix

* add ignite chain serve

* fix: phrasing when new files are created

* Update docs/docs/guide/03-hello.md

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* Update docs/docs/guide/03-hello.md

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* fix: removed grpc_* prefix from query files in scaffolded chain (ignite#3224)

* Removed grpc_* prefix from query files in scaffolded chain

* modified:changelog.md

* modified:changelog.md

* Removed grpc_* prefix from query files in scaffolded chain

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* chore: go formatting (ignite#3232)

Co-authored-by: aljo242 <aljo242@users.noreply.github.com>

* docs(cli): update generated docs (ignite#3207)

Co-authored-by: aljo242 <aljo242@users.noreply.github.com>
Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

* chore(docs): Fix some broken links and add a link checker for the markdown files (ignite#3219)

* Fix some broken links and add a link checker for the markdown files

* add md link checker config

* fix broken links

* remove redirect links from checker

* remove redirect links from checker

* remove duplicated config

* remove babylon blockchain link and change master to main for cosmos-sdk docs

* fix broken links

* remove sdk modules links because the redirection

* github moved links

* github moved links

* fix local links

* remove atom ide

* ignite guides

* add link checkr configs

* remove unused slash for urls

* exclude github 403 result links

* fix github link

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>

Co-authored-by: Albert Le Batteux <contact@albttx.tech>
Co-authored-by: Denis Fadeev <denis@fadeev.org>
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@tendermint.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Co-authored-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: aljo242 <aljo242@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@aljo242 aljo242 aljo242 approved these changes

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove grpc_* prefix from query files in scaffolded chains
4 participants
@SaumyaBhushan @tbruyelle @jeronimoalbi @aljo242