Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Image zoom plugin added #3106

Merged
merged 5 commits into from
Nov 18, 2022
Merged

docs: Image zoom plugin added #3106

merged 5 commits into from
Nov 18, 2022

Conversation

0fatih
Copy link
Contributor

@0fatih 0fatih commented Nov 12, 2022

I added the docusaurus-plugin-image-zoom as asked in #3099.

I tried and it works.

@0fatih
Copy link
Contributor Author

0fatih commented Nov 12, 2022

I don't have any idea what should I do with the build_and_deploy error:

/home/ubuntu/actions/runner-0/_work/_actions/FirebaseExtended/action-hosting-deploy/v0/bin/action.min.js:274
        throw new Error(`Input required and not supplied: ${name}`);
        ^

Error: Input required and not supplied: firebaseServiceAccount
    at Object.getInput (/home/ubuntu/actions/runner-0/_work/_actions/FirebaseExtended/action-hosting-deploy/v0/bin/action.min.js:274:15)
    at Object.<anonymous> (/home/ubuntu/actions/runner-0/_work/_actions/FirebaseExtended/action-hosting-deploy/v0/bin/action.min.js:11418:43)
    at Module._compile (node:internal/modules/cjs/loader:1[10](https://github.com/ignite/cli/actions/runs/3450626090/jobs/5759329366#step:7:11)1:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:[11](https://github.com/ignite/cli/actions/runs/3450626090/jobs/5759329366#step:7:12)53:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:[12](https://github.com/ignite/cli/actions/runs/3450626090/jobs/5759329366#step:7:13))
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:[17](https://github.com/ignite/cli/actions/runs/3450626090/jobs/5759329366#step:7:18):47

tbruyelle
tbruyelle previously approved these changes Nov 13, 2022
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY @0fatih LGTM

About the CI failing it's because you push from a forked repo, I'm not sure how to solve this. We'll see.

@tbruyelle
Copy link
Contributor

Can you run yarn in /docs so your change will also contain the package-lock.json update.

@0fatih
Copy link
Contributor Author

0fatih commented Nov 13, 2022

Hi @tbruyelle! I've already run yarn in /docs and it affected the yarn.lock file. I am not a JS expert, but, AFAIK npm affects to package-lock.json file. Do you want me to run npm i in /docs?

@tbruyelle
Copy link
Contributor

tbruyelle commented Nov 13, 2022

Hi @tbruyelle! I've already run yarn in /docs and it affected the yarn.lock file. I am not a JS expert, but, AFAIK npm affects to package-lock.json file. Do you want me to run npm i in /docs?

Indeed you're right, it seems like the docs were migrated to yarn without removing the package-lock.json and without adding yarn.lock. I don't know if it's intended or if it's a mistake, as I have poor knowledge in frontend stuff. Can you tell me @jeronimoalbi please ?

@aljo242 aljo242 changed the base branch from develop to main November 15, 2022 13:50
@aljo242 aljo242 dismissed tbruyelle’s stale review November 15, 2022 13:50

The base branch was changed.

@fadeev fadeev linked an issue Nov 18, 2022 that may be closed by this pull request
@aljo242
Copy link
Contributor

aljo242 commented Nov 18, 2022

@tbruyelle is there any issue with the yarn.lock file?

@tbruyelle
Copy link
Contributor

@tbruyelle is there any issue with the yarn.lock file?

Not really an issue since it was there before, but there's maybe something to fix, I created an issue for that, so we can merge this one.

@tbruyelle tbruyelle mentioned this pull request Nov 18, 2022
@aljo242 aljo242 merged commit 657e7a5 into ignite:main Nov 18, 2022
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* docusaurus-plugin-image-zoom plugin added

* add changelog

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: add image zoom plugin
3 participants