feat: ignite chain genesis config option 2.0 #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the context of the second PR? Is it easier to redo in order to address the double initialization refactoring? |
|
Yep - I'll just close the other one |
added 2 commits
November 4, 2022 08:54
|
@lubtd ready for review. Works for me finally |
|
Give me the time today to test it before merging, thanks |
|
Tested Everything is good from my side except the few comments👍 |
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
tbruyelle
approved these changes
Nov 7, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* add options * fix test * gen mocks * test * network config * account validation * expand validation rules * finalize genesis init * changelog * Update parser.go * Update init.go * add integration test * Update ignite/chainconfig/parser.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * remove TODO Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2852
Example:
Adds logic to
chainconfigfor a specificnetworkconfig. This config only includes theAccountsandGenesisfields, and has custom validation logic.