Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve config error handling #3052

Merged
merged 6 commits into from
Nov 4, 2022
Merged

feat: improve config error handling #3052

merged 6 commits into from
Nov 4, 2022

Conversation

jeronimoalbi
Copy link
Member

Resolves #3025

@jeronimoalbi jeronimoalbi added type:new To implement new feature. component:network labels Nov 3, 2022
@jeronimoalbi jeronimoalbi self-assigned this Nov 3, 2022
@jeronimoalbi jeronimoalbi mentioned this pull request Nov 3, 2022
Closed
aljo242
aljo242 suggested changes Nov 3, 2022
View reviewed changes
@tbruyelle
Copy link
Contributor

Maybe I missed something but for me ignite automatically upgrades the chain config file, are we talking about a something different here ?

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Nov 4, 2022 •
edited
Loading

Maybe I missed something but for me ignite automatically upgrades the chain config file, are we talking about a something different here ?

@tbruyelle that is true but only for the ignite chain commands. In the case of the ignite network commands we don't automatically upgrade. The issue happens for example when the app binary is build from a remotely cloned repository during publishing of a chain, when the version supported by the CLI being used to run the command is different than the config file version used by the remote repository.

@tbruyelle
Copy link
Contributor

Maybe I missed something but for me ignite automatically upgrades the chain config file, are we talking about a something different here ?

@tbruyelle that is true but only for the ignite chain commands. In the case of the ignite network commands we don't automatically upgrade. The issue happens for example when the app binary is build from a remotely cloned repository during publishing of a chain, when the version supported by the CLI being used to run the command is different than the config file version used by the remote repository.

OK thank you for the detailed explanation!

@aljo242 aljo242 merged commit 173a43a into develop Nov 4, 2022
@aljo242 aljo242 deleted the fix/chain-publish-config-version-error branch November 4, 2022 12:42
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@jeronimoalbi
feat: improve config error handling (ignite#3052)
7315659 
* refactor: improve config error handling

* chore: add Ignite CLI config version to `version` command output

* chore: fix typo

* chore: renamed argument variable

Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@aljo242 aljo242 aljo242 approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:network type:new To implement new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve errors when publishing a chain with an outdated config.yml
3 participants
@jeronimoalbi @tbruyelle @aljo242