Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove legacy launchpad code #3033

Merged
merged 9 commits into from
Nov 3, 2022
Merged

refactor: remove legacy launchpad code #3033

merged 9 commits into from
Nov 3, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Nov 1, 2022

  • Remove code for old SDK versions (Pre-stargate).
  • simplifies cosmosver pkg by removing the Family field.

@aljo242 aljo242 added the type:new To implement new feature. label Nov 1, 2022
@aljo242 aljo242 self-assigned this Nov 1, 2022
@aljo242 aljo242 mentioned this pull request Nov 1, 2022
Closed
4 tasks
tbruyelle
tbruyelle previously approved these changes Nov 2, 2022
View reviewed changes
lumtis
lumtis approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the Plugin interface in services/chain that could be removed unless we consider it as future proof in case new version with different API come up, but it seems unlikely

It complexifies the codebase right now

@aljo242 aljo242 mentioned this pull request Nov 3, 2022
Closed
@aljo242
Copy link
Contributor Author

aljo242 commented Nov 3, 2022

We have the Plugin interface in services/chain that could be removed unless we consider it as future proof in case new version with different API come up, but it seems unlikely

It complexifies the codebase right now

We should at least modify the name from plugin which is very unclear at this point. Opened #3049

@lumtis
Copy link
Contributor

lumtis commented Nov 3, 2022

Great, let's merge this one

@lumtis lumtis merged commit f239032 into develop Nov 3, 2022
@lumtis lumtis deleted the refactor/remove-launchpad branch November 3, 2022 16:29
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
refactor: remove legacy launchpad code (ignite#3033)
3735b05 
* remove family

* remove family

* remove StarportOnlySupported error

* remove dead code

* lint fixes

* changelog

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@lumtis lumtis lumtis approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@aljo242 aljo242

Labels
type:new To implement new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljo242 @lumtis @tbruyelle