Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(templates): app.go hooks #3031

Merged
merged 5 commits into from
Nov 2, 2022
Merged

refactor(templates): app.go hooks #3031

merged 5 commits into from
Nov 2, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Nov 1, 2022

Closes #3019

Move hooks initialization in app/app.go to after all keepers are initialized.

Adds a "hooks" section, and an empty gov hooks call for users as well.

@aljo242 aljo242 self-assigned this Nov 1, 2022
@aljo242 aljo242 merged commit de7fe0e into develop Nov 2, 2022
@aljo242 aljo242 deleted the refactor/app-hooks branch November 2, 2022 13:16
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
refactor(templates): app.go hooks (ignite#3031)
e71af9e 
* move hook logic

* move

* fix hooks section

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@aljo242 aljo242

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hooks have not initialized keepers because of incorrect ordering of initialization in app.go
3 participants
@aljo242 @tbruyelle @jeronimoalbi