Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide ignite scaffold band #2993

Merged
merged 5 commits into from
Oct 26, 2022
Merged

chore: hide ignite scaffold band #2993

merged 5 commits into from
Oct 26, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Oct 25, 2022

Closes #2887

Keeps the internal functionality, but just removes the exposed command. If we maintain the functionality internally, but just deprecate it.

Perhaps we can remove altogether, but I wanted to check with y'all first.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Visit the preview URL for this PR (updated for commit 3341ee2):

https://ignitesrvc-d--pr2993-chore-hide-band-ul3rv0ed.web.app

(expires Tue, 01 Nov 2022 22:37:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 60382552e86c69890c026e09478220ea153394a8

@aljo242 aljo242 requested a review from jeronimoalbi October 25, 2022 15:40
@lumtis lumtis merged commit e5defbd into develop Oct 26, 2022
@lumtis lumtis deleted the chore/hide-band branch October 26, 2022 00:50
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* deprecate

* remove command

* refactor docs

* re-add file and hide

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the scaffold band command and remove info about Bandchain from the docs
3 participants