fix: improve faucet reliability #1974

lumtis · 2022-01-06T14:22:09Z

batch all coin transfers into one transaction
avoid concurrent transfer
add integration tests for faucet
fix TotalTransferredAmount that was returning 0 with coins with multiple denoms
wait transfer to be mined for faucet to complete

chore: sync master

Co-authored-by: Danilo Pantani <danpantani@gmail.com>

Grammar fix at line 7. Co-authored-by: Danilo Pantani <danpantani@gmail.com>

Grammar fix at line 55. Co-authored-by: Danilo Pantani <danpantani@gmail.com>

ilgooz

Thanks for taking a lead on this. 🙌

The base branch had some changes, can we rebase it again?

starport/pkg/cosmoscoin/coin.go

integration/app/faucet_test.go

integration/env.go

into release/v0.19.2

lumtis · 2022-01-07T10:07:11Z

Open for reviews :)
Don't be surprised with the commits, I messed up a bit with git

ilgooz

a few more feedbacks 👍

changelog.md

integration/faucet/faucet_test.go

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>

…ndermint/starport into fix/faucet-account-sequence-2

This reverts commit 3aa7d47.

This reverts commit e826818.

This reverts commit 78e098a.

This reverts commit 3577095.

This reverts commit 56a27d0.

This reverts commit 9176081.

ilgooz

Since the API has changed can you please update the /openapi/openapi.yml.tmpl spec as well? After updating, sending tokens from the Swagger UI needs to work OK.

starport/pkg/cosmosfaucet/transfer.go

lumtis · 2022-01-12T16:39:01Z

Since the API has changed can you please update the /openapi/openapi.yml.tmpl spec as well? After updating, sending tokens from the Swagger UI needs to work OK.

Good point. I also removed Coins from the response since it doesn't add value. Either all coins or not are successful sent

lumtis · 2022-01-12T16:39:51Z

Small update: added a check for the tx successful completion 08190a4

starport/pkg/chaincmd/runner/chain.go

* feat(changelog): reset `Unreleased` section (ignite#1946) * fix(docs): change lazy ledger to celestia (ignite#1952) * (docs): fix typo in hello.md (ignite#1951) Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Minor grammar fix (ignite#1950) Grammar fix at line 7. Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Minor grammar fix (ignite#1949) Grammar fix at line 55. Co-authored-by: Danilo Pantani <danpantani@gmail.com> * docs: add v0.19 to the readme (ignite#1956) * Single transfer * initialize faucet tests * transfer mutex * batch request test * Fix total transfer * Add wait tx * lint * use http client * move test * Refacto faucet served * use cosmosclient * remove coins * Single transfer * initialize faucet tests * transfer mutex * batch request test * Fix total transfer * Add wait tx * lint * use http client * move test * Refacto faucet served * use cosmosclient * remove coins * Update integration/faucet/faucet_test.go Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> * Update integration/faucet/faucet_test.go Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> * remove must * Revert "feat(changelog): reset `Unreleased` section (ignite#1946)" This reverts commit 3aa7d47. * Revert "fix(docs): change lazy ledger to celestia (ignite#1952)" This reverts commit e826818. * Revert "(docs): fix typo in hello.md (ignite#1951)" This reverts commit 78e098a. * Revert "Minor grammar fix (ignite#1950)" This reverts commit 3577095. * Revert "Minor grammar fix (ignite#1949)" This reverts commit 56a27d0. * Revert "docs: add v0.19 to the readme (ignite#1956)" This reverts commit 9176081. * suggestion * update openapi * add tx code check * update test * lint * Ensure JSON encoding on tx parsing Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: 0xkrane <89357497+0xkrane@users.noreply.github.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: sgmoore <git-sgmoore@users.noreply.github.com> Co-authored-by: Denis Fadeev <denis@fadeev.org>

ilgooz and others added 12 commits December 17, 2021 16:33

chore: sync master (#1945)

6e55daf

chore: sync master

feat(changelog): reset Unreleased section (#1946)

3aa7d47

chore: sync master

73a8ec0

chore: sync master

fix(docs): change lazy ledger to celestia (#1952)

e826818

(docs): fix typo in hello.md (#1951)

78e098a

Co-authored-by: Danilo Pantani <danpantani@gmail.com>

Minor grammar fix (#1950)

3577095

Grammar fix at line 7. Co-authored-by: Danilo Pantani <danpantani@gmail.com>

Minor grammar fix (#1949)

56a27d0

Grammar fix at line 55. Co-authored-by: Danilo Pantani <danpantani@gmail.com>

docs: add v0.19 to the readme (#1956)

9176081

Single transfer

9fe6d4a

initialize faucet tests

956ae82

transfer mutex

49b9927

batch request test

297ccd7

ilgooz reviewed Jan 6, 2022

View reviewed changes

This was linked to issues Jan 6, 2022

pkg/cosmosfaucet: fix race condition during transfer #1965

Closed

Starport relayer connect fails to increase balance of default accounts on first time usage #1953

Closed

lumtis added 15 commits January 6, 2022 19:43

Fix total transfer

fbbd0f5

Add wait tx

f51fb6d

lint

fe4fe14

use http client

6b3712a

move test

20afede

Refacto faucet served

72e6efa

use cosmosclient

5763afe

remove coins

57542df

Merge branch 'release/v0.19.2' of https://github.com/tendermint/starport

e70a39f

into release/v0.19.2

Merge branch 'release/v0.19.2' into fix/faucet-account-sequence-2

e4650a0

Single transfer

eac8ad4

initialize faucet tests

b151775

transfer mutex

9384815

batch request test

51e3ede

Fix total transfer

58ab4e5

lumtis requested a review from Pantani as a code owner January 7, 2022 10:06

lumtis requested a review from ilgooz January 10, 2022 12:42

ilgooz requested changes Jan 11, 2022

View reviewed changes

lumtis and others added 10 commits January 11, 2022 17:49

Update integration/faucet/faucet_test.go

68e30e1

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>

Update integration/faucet/faucet_test.go

86db09c

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>

remove must

ee956e5

Merge branch 'fix/faucet-account-sequence-2' of https://github.com/te…

5d4828d

…ndermint/starport into fix/faucet-account-sequence-2

Revert "feat(changelog): reset Unreleased section (#1946)"

c12762b

This reverts commit 3aa7d47.

Revert "fix(docs): change lazy ledger to celestia (#1952)"

34a0ee4

This reverts commit e826818.

Revert "(docs): fix typo in hello.md (#1951)"

c975af9

This reverts commit 78e098a.

Revert "Minor grammar fix (#1950)"

dbc3402

This reverts commit 3577095.

Revert "Minor grammar fix (#1949)"

790f081

This reverts commit 56a27d0.

Revert "docs: add v0.19 to the readme (#1956)"

dde15f2

This reverts commit 9176081.

lumtis requested a review from ilgooz January 11, 2022 17:18

ilgooz requested changes Jan 12, 2022

View reviewed changes

ilgooz reviewed Jan 12, 2022

View reviewed changes

starport/pkg/cosmosfaucet/transfer.go Outdated Show resolved Hide resolved

lumtis added 4 commits January 12, 2022 16:09

suggestion

6c797dd

update openapi

8b39e2c

add tx code check

08190a4

update test

f251864

lumtis requested a review from ilgooz January 12, 2022 16:39

lint

086e925

ilgooz reviewed Jan 13, 2022

View reviewed changes

starport/pkg/chaincmd/runner/chain.go Outdated Show resolved Hide resolved

Ensure JSON encoding on tx parsing

ef5125c

ilgooz merged commit b81c51b into release/v0.19.2 Jan 13, 2022

ilgooz deleted the fix/faucet-account-sequence-2 branch January 13, 2022 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve faucet reliability #1974

fix: improve faucet reliability #1974

lumtis commented Jan 6, 2022 •

edited

Loading

ilgooz left a comment

lumtis commented Jan 7, 2022

ilgooz left a comment

ilgooz left a comment

lumtis commented Jan 12, 2022

lumtis commented Jan 12, 2022

fix: improve faucet reliability #1974

fix: improve faucet reliability #1974

Conversation

lumtis commented Jan 6, 2022 • edited Loading

ilgooz left a comment

Choose a reason for hiding this comment

lumtis commented Jan 7, 2022

ilgooz left a comment

Choose a reason for hiding this comment

ilgooz left a comment

Choose a reason for hiding this comment

lumtis commented Jan 12, 2022

lumtis commented Jan 12, 2022

lumtis commented Jan 6, 2022 •

edited

Loading