feat(network): simulate requests

starport/cmd/network.go

@@ -12,6 +12,7 @@ import (
 	"github.com/tendermint/starport/starport/pkg/gitpod"
 	"github.com/tendermint/starport/starport/services/network"
 	"github.com/tendermint/starport/starport/services/network/networkchain"
+	"github.com/tendermint/starport/starport/services/network/networktypes"
 )
 
 var (
@@ -143,8 +144,8 @@ func getNetworkCosmosClient(cmd *cobra.Command) (cosmosclient.Client, error) {
 	cosmosOptions := []cosmosclient.Option{
 		cosmosclient.WithHome(cosmosaccount.KeyringHome),
 		cosmosclient.WithNodeAddress(spnNodeAddress),
-		cosmosclient.WithAddressPrefix(networkchain.SPN),
-		cosmosclient.WithUseFaucet(spnFaucetAddress, networkchain.SPNDenom, 5),
+		cosmosclient.WithAddressPrefix(networktypes.SPN),
+		cosmosclient.WithUseFaucet(spnFaucetAddress, networktypes.SPNDenom, 5),
 		cosmosclient.WithKeyringServiceName(cosmosaccount.KeyringServiceName),
 	}
 

starport/cmd/network_request.go

@@ -15,6 +15,7 @@ func NewNetworkRequest() *cobra.Command {
 		NewNetworkRequestList(),
 		NewNetworkRequestApprove(),
 		NewNetworkRequestReject(),
+		NewNetworkRequestVerify(),
 	)
 
 	return c

starport/cmd/network_request_approve.go

@@ -3,6 +3,7 @@ package starportcmd
 import (
 	"fmt"
 
+	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 	"github.com/tendermint/starport/starport/pkg/clispinner"
 	"github.com/tendermint/starport/starport/pkg/numbers"
@@ -61,12 +62,14 @@ func networkRequestApproveHandler(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
+	// if requests must be verified, we simulate the chain in a temporary directory with the requests
 	if !noVerification {
-		err := n.VerifyRequests(cmd.Context(), launchID, ids...)
-		if err != nil {
-			return err
+		if err := verifyRequest(cmd.Context(), nb, n, launchID, ids...); err != nil {
+			return errors.Wrap(err, "request(s) not valid")
 		}
+		fmt.Printf("%s Request(s) %s verified\n", clispinner.OK, numbers.List(ids, "#"))
 	}
+
 	// Submit the approved requests
 	reviewals := make([]network.Reviewal, 0)
 	for _, id := range ids {

starport/cmd/network_request_verify.go

@@ -0,0 +1,114 @@
+package starportcmd
+
+import (
+	"context"
+	"fmt"
+	"os"
+
+	"github.com/spf13/cobra"
+	"github.com/tendermint/starport/starport/pkg/chaincmd"
+	"github.com/tendermint/starport/starport/pkg/clispinner"
+	"github.com/tendermint/starport/starport/pkg/numbers"
+	"github.com/tendermint/starport/starport/services/network"
+	"github.com/tendermint/starport/starport/services/network/networkchain"
+)
+
+// NewNetworkRequestVerify creates a new request approve
+// command to approve requests for a chain.
+func NewNetworkRequestVerify() *cobra.Command {
+	c := &cobra.Command{
+		Use:     "verify [launch-id] [number<,...>]",
+		Aliases: []string{"accept"},
+		Short:   "Verify the request and simulate the chain genesis from them",
+		RunE:    networkRequestVerifyHandler,
+		Args:    cobra.ExactArgs(2),
+	}
+	c.Flags().AddFlagSet(flagNetworkFrom())
+	c.Flags().AddFlagSet(flagSetHome())
+	c.Flags().AddFlagSet(flagSetKeyringBackend())
+	return c
+}
+
+func networkRequestVerifyHandler(cmd *cobra.Command, args []string) error {
+	// initialize network common methods
+	nb, err := newNetworkBuilder(cmd)
+	if err != nil {
+		return err
+	}
+	defer nb.Cleanup()
+
+	// parse launch ID
+	launchID, err := network.ParseLaunchID(args[0])
+	if err != nil {
+		return err
+	}
+
+	// get the list of request ids
+	ids, err := numbers.ParseList(args[1])
+	if err != nil {
+		return err
+	}
+
+	n, err := nb.Network()
+	if err != nil {
+		return err
+	}
+
+	// verify the requests
+	if err := verifyRequest(cmd.Context(), nb, n, launchID, ids...); err != nil {
+		fmt.Printf("%s Request(s) %s not valid\n", clispinner.NotOK, numbers.List(ids, "#"))
+		return err
+	}
+
+	nb.Spinner.Stop()
+	fmt.Printf("%s Request(s) %s verified\n", clispinner.OK, numbers.List(ids, "#"))
+	return nil
+}
+
+// verifyRequest initialize the chain from the launch ID in a temporary directory
+// and simulate the launch of the chain from genesis with the request IDs
+func verifyRequest(
+	ctx context.Context,
+	nb NetworkBuilder,
+	n network.Network,
+	launchID uint64,
+	requestIDs ...uint64,
+) error {
+	// initialize the chain with a temporary dir
+	chainLaunch, err := n.ChainLaunch(ctx, launchID)
+	if err != nil {
+		return err
+	}
+
+	homeDir, err := os.MkdirTemp("", "")
+	if err != nil {
+		return err
+	}
+	defer os.RemoveAll(homeDir)
+
+	c, err := nb.Chain(
+		networkchain.SourceLaunch(chainLaunch),
+		networkchain.WithHome(homeDir),
+		networkchain.WithKeyringBackend(chaincmd.KeyringBackendTest),
+	)
+	if err != nil {
+		return err
+	}
+
+	// fetch the current genesis information and the requests for the chain for simulation
+	genesisInformation, err := n.GenesisInformation(ctx, launchID)
+	if err != nil {
+		return err
+	}
+
+	requests, err := n.RequestFromIDs(ctx, launchID, requestIDs...)
+	if err != nil {
+		return err
+	}
+
+	if err := c.SimulateRequests(ctx, genesisInformation, requests); err != nil {
+		return err
+	}
+
+	return nil
+}

starport/pkg/clispinner/icon.go

@@ -4,6 +4,8 @@ import "github.com/fatih/color"
 
 var (
 	// OK is an OK mark.
-	OK     = color.New(color.FgGreen).SprintFunc()("✔")
+	OK = color.New(color.FgGreen).SprintFunc()("✔")
+	// NotOK is a red cross mark
+	NotOK  = color.New(color.FgRed).SprintFunc()("✘")
 	Bullet = color.New(color.FgYellow).SprintFunc()("⋆")
 )

starport/services/network/join.go

@@ -9,7 +9,7 @@ import (
 	"github.com/tendermint/starport/starport/pkg/cosmoserror"
 	"github.com/tendermint/starport/starport/pkg/cosmosutil"
 	"github.com/tendermint/starport/starport/pkg/events"
-	"github.com/tendermint/starport/starport/services/network/networkchain"
+	"github.com/tendermint/starport/starport/services/network/networktypes"
 )
 
 // Join to the network.
@@ -49,7 +49,7 @@ func (n Network) Join(
 	}
 
 	// change the chain address prefix to spn
-	accountAddress, err := cosmosutil.ChangeAddressPrefix(gentxInfo.DelegatorAddress, networkchain.SPN)
+	accountAddress, err := cosmosutil.ChangeAddressPrefix(gentxInfo.DelegatorAddress, networktypes.SPN)
 	if err != nil {
 		return err
 	}
@@ -77,7 +77,7 @@ func (n Network) sendAccountRequest(
 	accountAddress string,
 	amount sdk.Coin,
 ) (err error) {
-	address := n.account.Address(networkchain.SPN)
+	address := n.account.Address(networktypes.SPN)
 	n.ev.Send(events.New(events.StatusOngoing, "Verifying account already exists "+address))
 
 	// if is custom gentx path, avoid to check account into genesis from the home folder
@@ -101,7 +101,7 @@ func (n Network) sendAccountRequest(
 	}
 
 	msg := launchtypes.NewMsgRequestAddAccount(
-		n.account.Address(networkchain.SPN),
+		n.account.Address(networktypes.SPN),
 		launchID,
 		accountAddress,
 		sdk.NewCoins(amount),
@@ -148,7 +148,7 @@ func (n Network) sendValidatorRequest(
 	}
 
 	msg := launchtypes.NewMsgRequestAddValidator(
-		n.account.Address(networkchain.SPN),
+		n.account.Address(networktypes.SPN),
 		launchID,
 		valAddress,
 		gentx,

starport/services/network/launch.go

@@ -9,7 +9,7 @@ import (
 	"github.com/tendermint/starport/starport/pkg/cosmoserror"
 	"github.com/tendermint/starport/starport/pkg/events"
 	"github.com/tendermint/starport/starport/pkg/xtime"
-	"github.com/tendermint/starport/starport/services/network/networkchain"
+	"github.com/tendermint/starport/starport/services/network/networktypes"
 )
 
 // LaunchParams fetches the chain launch module params from SPN
@@ -32,7 +32,7 @@ func (n Network) TriggerLaunch(ctx context.Context, launchID uint64, remainingTi
 	var (
 		minLaunch = xtime.Seconds(params.MinLaunchTime)
 		maxLaunch = xtime.Seconds(params.MaxLaunchTime)
-		address   = n.account.Address(networkchain.SPN)
+		address   = n.account.Address(networktypes.SPN)
 	)
 	switch {
 	case remainingTime == 0:

starport/services/network/network.go

@@ -25,6 +25,8 @@ type Chain interface {
 	GenesisPath() (string, error)
 	GentxsPath() (string, error)
 	DefaultGentxPath() (string, error)
+	AppTOMLPath() (string, error)
+	ConfigTOMLPath() (string, error)
 	Peer(ctx context.Context, addr string) (string, error)
 }
 

starport/services/network/networkchain/home.go

@@ -4,6 +4,8 @@ import (
 	"os"
 	"path/filepath"
 	"strconv"
+
+	"github.com/tendermint/starport/starport/services/network/networktypes"
 )
 
 // ChainHome returns the default home dir used for a chain from SPN.
@@ -13,7 +15,7 @@ func ChainHome(launchID uint64) (path string) {
 		panic(err)
 	}
 
-	return filepath.Join(home, SPN, strconv.FormatUint(launchID, 10))
+	return filepath.Join(home, networktypes.SPN, strconv.FormatUint(launchID, 10))
 }
 
 // IsChainHomeExist checks if a home with the provided launchID already exist.

starport/services/network/networkchain/home_test.go

@@ -7,15 +7,16 @@ import (
 
 	"github.com/stretchr/testify/require"
 	"github.com/tendermint/starport/starport/services/network/networkchain"
+	"github.com/tendermint/starport/starport/services/network/networktypes"
 )
 
 func TestChainHome(t *testing.T) {
 	home, err := os.UserHomeDir()
 	require.NoError(t, err)
 
 	chainHome := networkchain.ChainHome(0)
-	require.Equal(t, filepath.Join(home, networkchain.SPN, "0"), chainHome)
+	require.Equal(t, filepath.Join(home, networktypes.SPN, "0"), chainHome)
 
 	chainHome = networkchain.ChainHome(10)
-	require.Equal(t, filepath.Join(home, networkchain.SPN, "10"), chainHome)
+	require.Equal(t, filepath.Join(home, networktypes.SPN, "10"), chainHome)
 }

starport/services/network/networkchain/networkchain.go

@@ -17,14 +17,6 @@ import (
 	"github.com/tendermint/starport/starport/services/network/networktypes"
 )
 
-const (
-	// SPN name used as an address prefix and as a home dir for chains to publish.
-	SPN = "spn"
-
-	// SPNDenom is the denom used for the spn chain native token
-	SPNDenom = "uspn"
-)
-
 // Chain represents a network blockchain and lets you interact with its source code and binary.
 type Chain struct {
 	id string
@@ -132,10 +124,10 @@ func New(ctx context.Context, ar cosmosaccount.Registry, source SourceOption, op
 	c := &Chain{
 		ar: ar,
 	}
+	source(c)
 	for _, apply := range options {
 		apply(c)
 	}
-	source(c)
 
 	c.ev.Send(events.New(events.StatusOngoing, "Fetching the source code"))
 
@@ -204,6 +196,14 @@ func (c Chain) DefaultGentxPath() (path string, err error) {
 	return c.chain.DefaultGentxPath()
 }
 
+func (c Chain) AppTOMLPath() (string, error) {
+	return c.chain.AppTOMLPath()
+}
+
+func (c Chain) ConfigTOMLPath() (string, error) {
+	return c.chain.ConfigTOMLPath()
+}
+
 func (c Chain) SourceURL() string {
 	return c.url
 }

starport/services/network/networkchain/prepare.go

@@ -56,6 +56,14 @@ func (c Chain) Prepare(ctx context.Context, gi networktypes.GenesisInformation)
 	if err != nil {
 		return err
 	}
+
+	// ensure genesis has a valid format
+	err = cmd.ValidateGenesis(ctx)
+	if err != nil {
+		return err
+	}
+
+	// reset the saved state in case the chain has been started before
 	return cmd.UnsafeReset(ctx)
 }
 
@@ -69,13 +77,13 @@ func (c Chain) buildGenesis(ctx context.Context, gi networktypes.GenesisInformat
 	}
 
 	// apply genesis information to the genesis
-	if err := c.applyGenesisAccounts(ctx, gi.GenesisAccounts, addressPrefix); err != nil {
+	if err := c.applyGenesisAccounts(ctx, gi.GetGenesisAccounts(), addressPrefix); err != nil {
 		return errors.Wrap(err, "error applying genesis accounts to genesis")
 	}
-	if err := c.applyVestingAccounts(ctx, gi.VestingAccounts, addressPrefix); err != nil {
+	if err := c.applyVestingAccounts(ctx, gi.GetVestingAccounts(), addressPrefix); err != nil {
 		return errors.Wrap(err, "error applying vesting accounts to genesis")
 	}
-	if err := c.applyGenesisValidators(ctx, gi.GenesisValidators); err != nil {
+	if err := c.applyGenesisValidators(ctx, gi.GetGenesisValidators()); err != nil {
 		return errors.Wrap(err, "error applying genesis validators to genesis")
 	}