-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.0.10-rc #133
Merged
Merged
Release/v0.0.10-rc #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor folder structure for main & cli * introduced a new package called `interface` as a single bridge to expose Starport's features to possibly multiple targets e.g. cli, grpc, http. * cmd and main packages are moved under `interface/cli/starport`. * `starport` package name for the `main` program is chosen to enable easy, named installations with `go get github.com/tendermint/starport/...` which should produce the binary with `starport` name by default. * simplifed the `Makefile` regarding to other changes. * fix ui and app template paths * change ./scripts/dev as ./scripts/starport * fix typed template path * templates: revert template paths for packr
* Update go.mod to Cosmos SDK v0.39.0 * Fix issue with pruning options * Fix acc number and seq fetching
in order to: * reduce package level globals, * increase configurability of the root command by outside caller where such options can be passed as an argument to `starportcmd.New()`.
* reconstructed organization of serve command.
we are in a refactoring period and it is safe to ignore linter errors at this stage since some related code will be changed.
* reconstructed organization of app command.
* reconstructed organization of add command. solves a part of #56.
* ci: run unit tests for Starport resolved #29. * ci: fix unit test
* interface/cli/starport/cmd: made typed command newable * reconstructed organization of `typed` command. solves a part of #56. * interface/cli/starport/cmd: fix typo on command * interface/cli/starport/cmd: fix typo on command
* Update readme.md The README needs more beginner level content. I added links to Denis' tutorials (we can replace this with a link to tutorials.cosmos.network later), communication channels, and improved organization a bit. * Update readme.md * Replace me with user1 as in init script Co-authored-by: Denis Fadeev <denis@fadeev.org>
for short-running command executions. * introduced new `pkg/cmdrunner` pkg. (tests will be added later once we have finized its public APIs)
* Update to @cosmjs/launchpad * Use public method getAccounts in frontend store
* starport/cmd: use cmdrunner to start cli servers * some refactoring related to `pkg/cmdrunner` and `starport/cmd`. * starport/cmd: run cli servers and dev server in parallel * trig ci
and more simplifications on serve.
to the new services/serve package.
resolves #88.
as a starting point to refactor development server.
* services/serve: refactor dev server handler * updated frontend bindings. * added new `pkg/xhttp` helper. * added new `pkg/httpstatuschecker` helper. * services/serve: simplify server status check and add concurrent checks. * services/serve: rework def of dev server's /status enpoint
* services/serve now uses pkg/fswatcher to watch for changes on user's app.
* add graceful shutdown to dev server * handle all async errors * exclude hidden files from watch list * stabilize cancelation for serve and other async tasks
* Add custom prefix support * Replace --prefix with --address-prefix * Fix custom denom in init
to init/config user's app. instead execute command via Go or programatically as possible. * Windows is now supported but not stable yet.
* services/serve: simplify concurrency * cleanup. * fix git version retrieval. * fix app backend watch
* services/serve: introduce config.yml for now it only supports account creation with the format below: ```yml accounts: - name: me coins: ["1000token", "100000000stake"] - name: you coins: ["5000token"] ``` * Makefile in the user app's is removed in favor of adding config.yml. * some util packages added under pkg/ needed for this feature. solves a part of #106, #41. * fix tests
* services/serve: wait for a fix on build error instead of aborting the serve on an error related to building the app's backend, wait for a fix and try to rebuild. resolves #107. * improve logs * extend the scope of build error handling * improve logs
* services/serve: omit build error on cancellation previously when user just started to `serve` during the process of building the user's app; and if there is a cancelation made by sending a ^C signal during that period, `serve` was thinking that app failed to build and printing an empty build error log before aborting the serving process. this commit fixes that. before: ``` 📦 Installing dependencies... ^Ccannot build app: waiting for a fix before retrying... aborted ``` after: ``` 📦 Installing dependencies... ^Caborted ``` * open commented out code
* update starport to 0.39 * make it work * Update starport/templates/app/templates/cmd/{{binaryNamePrefix}}d/main.go.plush Co-authored-by: Denis Fadeev <denis@fadeev.org> * Removed alias from TYPE template Co-authored-by: Denis Fadeev <denis@fadeev.org>
* services/serve: add prefixes to verbose logs * added new pkg/lineprefixer. * added new pkg/prefixgen. * added options builder to pkg/cmdrunner/step. * cosmetics. * fix tests & add missing file * add STARPORT prefix to native logs * add buildLog log type. * reorganize verbose logs. * fix linter * fix verbose logs
reverted the prev one #132 in favor of this PR to make a merge this time instead of squashing. |
ilgooz
added a commit
that referenced
this pull request
Aug 7, 2020
Merge pull request #133 from tendermint/release/v0.0.10-rc
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Release/v0.0.10-rc
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Merge pull request ignite#133 from tendermint/release/v0.0.10-rc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.