weaker Smagorinsky #167
Closed
weaker Smagorinsky #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscosity); do xchng_sgs_tnsr_diag
|
Double-checked and the master formulation is correct (also agrees with SGS boussinesq from libmpdata). One remaining issue may be that 2/3 of divergence of velocity is not substracted from the diagonal of the deformation tensor (there's an open issue about it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eddy viscosity, use tdef_sq instead of sqrt(tdef_sq).
Default Smagorinsky in mpdata does the same, but isn't sqrt(tdef_sq) in agreement with the formulas? Double-check the formulas and the computation...
This makes eddy viscosity smaller, hence Deardorffs char length (dxdydz)^(1/3) can be used instead of dz (e.g. in Dycoms).