Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InstaID precision without using bigint #260

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

Azureit
Copy link
Contributor

@Azureit Azureit commented Jan 26, 2022

With this patch you return the real InstaID, if needed to be checked or used for something else. The one returned now is not precise.

With this patch you return the real InstaID, if needed to be checked or used for something else. The one returned now is not precise.
@Azureit
Copy link
Contributor Author

Azureit commented Jan 27, 2022

@HuiiBuh What do you think?
It's good for me, but please optimize and format to meet your standards.

@HuiiBuh
Copy link
Collaborator

HuiiBuh commented Jan 27, 2022

First of all, thanks for the PR.

Honestly, I think you have to put in some comments to explain what exactly you are doing. I half a year I am sure that I will have no clue what this does anymore.

And if you want to edit a PR, just make some edits in the file (comments), commit the changes and push. This will automatically update the PR for you.
And some general advice.

  • In js|ts we use camelCase not snake_case.
  • Don't use magic numbers and don't document them (for a bad example just see my own code which just uses the number 1314220021721 without explaining, that this is the instagram epoch)

@Azureit
Copy link
Contributor Author

Azureit commented Jan 28, 2022

@HuiiBuh What do you think now?
Thanks for the tip about editing the branch would update the pr.

@HuiiBuh
Copy link
Collaborator

HuiiBuh commented Jan 28, 2022

Thanks for the edit and the pr.
I will merge it later and release a new version

@HuiiBuh HuiiBuh merged commit df89f2a into igdownloader:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants