Remove polyfills #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,11 @@ | |||
| ## | |||
| # Hawk entry point. | |||
| # | |||
| # | |||
|
|
|||
| require 'active_support/core_ext/array/wrap' | |||
There was a problem hiding this comment.
Is this enough? Or, why is it needed? We are using pluralize but not requiring it explicitly.
There was a problem hiding this comment.
I know, that's strange, but without this explicit require I get a
#<NoMethodError: undefined method 'wrap' for Array:Class>. I have the feeling it has to do with ActiveSupport's require-ing and autoloading.
|
Oh, look how a bit of Not Invented Here syndrome goes away. @jblackman no more refinements in Hawk, you can start testing it on Ruby 1.9 :-) |
tagliala
added a commit
that referenced
this pull request
Sep 20, 2024
This code is not being required Ref: #5
Merged
tagliala
added a commit
that referenced
this pull request
Sep 20, 2024
This code is not being required Ref: #5
tagliala
added a commit
that referenced
this pull request
Sep 20, 2024
This code is not being required and references non-existing files Ref: #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.