Merge pull request #261 from ifad/chore/fix-some-offences-in-non-prod

Fix safe offences in non-production code

spec/integration/callback.rb

@@ -2,7 +2,6 @@
 #
 # Simple sinatra app to receive and display callbacks
 #
-require 'pp'
 require 'sinatra'
 
 set :port, 9230

spec/lib/app_spec.rb

@@ -13,12 +13,12 @@
   let(:author) { 'spliffy' }
 
   def show_backtrace response
-    if response.status == 500
-      begin
-        puts JSON.pretty_generate(JSON.parse response.body)
-      rescue StandardError => e
-        puts response.body
-      end
+    return unless response.status == 500
+
+    begin
+      puts JSON.pretty_generate(JSON.parse response.body)
+    rescue StandardError => e
+      puts response.body
     end
   end
 

spec/lib/document_spec.rb

@@ -73,7 +73,7 @@
     it 'runs' do
       dir = document.directory
       expect(dir).to_not be_nil
-      expect(File.exists? dir).to eq true
+      expect(File.exist? dir).to eq true
     end
   end
 
@@ -131,7 +131,7 @@
     it 'runs' do
       version = document.new_version
       expect(version).to_not be_nil
-      expect(File.exists? document.directory + version).to eq true
+      expect(File.exist? document.directory + version).to eq true
       new_doc = described_class.load storage_dir, doc_key
       expect(new_doc.versions.include? version).to eq true
     end
@@ -142,21 +142,21 @@
       file = __FILE__
       body = File.read(file)
       document.add_file 'v002', File.basename(file), body
-      expect(File.exists? document.directory + 'v002' + File.basename(file)).to eq true
+      expect(File.exist? document.directory + 'v002' + File.basename(file)).to eq true
     end
     it 'runs with author' do
       file = __FILE__
       body = File.read(file)
       document.add_file 'v002', File.basename(file), body, author
-      expect(File.exists? document.directory + 'v002' + File.basename(file)).to eq true
-      expect(File.exists? document.directory + 'v002' + described_class::AUTHOR_FILE).to eq true
+      expect(File.exist? document.directory + 'v002' + File.basename(file)).to eq true
+      expect(File.exist? document.directory + 'v002' + described_class::AUTHOR_FILE).to eq true
       expect(File.read(document.directory + 'v002' + described_class::AUTHOR_FILE).chomp).to eq author
     end
     it 'runs with IO for body' do
       file = __FILE__
       body = File.open(file)
       document.add_file 'v002', File.basename(file), body
-      expect(File.exists? document.directory + 'v002' + File.basename(file)).to eq true
+      expect(File.exist? document.directory + 'v002' + File.basename(file)).to eq true
     end
   end