Activitypub/Sprint 1

[mediaformat]

ActivityPub Sprint 1

#3186

• Setup / Planning
• Add new json_activity templates and endpoints (profiles, posts)
• Add ActivityPub actor URI to webfinger
• Add ActivityPub link-rel discovery to html templates

Additional

• Adjust parseURLs to allow exclusion of <wbr /> injection
• Fix getTags regex to ignore url fragments parseHashTag() matches url fragments #3197

Here's what I fixed or added:

This PR is focused on the Actor/user Profile and default enabled Post types (note, article, image).
The PR is pointing to idno:dev branch but perhaps a feature branch might be more appropriate.

• Some methods to the User class
  • getActorID
  • getIconObject
  • getPublicKey
  • getPublicKeyPem
  • getPrivateKey
  • generateKeyPair
  • ...
• Some methods to the Entity class
  • ...
• A separate /actor/ route specifically for ActivityPub profile
• A new activitypub default/shell template for <link rel="alternate" type="application/activity+json" ...>

Here's why I did it:

Separate Actor routes

Content-Negotiation

By adding separate actor routes, we seek to avoid Content-Negotiation (accessing the same route with different Accept headers) which can cause different servers, caching solutions to cache and serve the wrong version (html/json).

Mastodon's Signature verification issue

While it would be possible to use existing routes with the ?_t=activitypub template query, mastodon has a known issue with verifying HTTP signatures. Though the issue was recently solved in mastodon, it requires a second request for backwards compatibility.

Checklist: ([x] to check/tick the boxes)

• This pull request addresses a single issue
• If this code includes interface changes, I've included screenshots in this Pull Request thread
• I've adhered to Known's style guide (these codesniffer rules might help!)
• My git branch is named in a descriptive way - i.e., yourname-summary-of-issue
• I've tested my code in-browser
• My code contains descriptive comments
• I've added tests where applicable, and...
• I can run the unit tests successfully.

[mediaformat]

Additional Notes:
Because ActivityPub is to be part of the core, I've put most methods in the Entity class, while some may be more related to formatting, but these include Formatted in the method name for clarity.

I'm making use of existing parseHashTag() and parseURL() methods for formatting, and though they do work for now, they each have issues, I'll address in the coming days:

• parseHashTag() will match a url's fragment (bug parseHashTag() matches url fragments #3197)
• parseURL() inserts a <wbr> tag, which mastodon ignores, but ultimately a separate method should be used.

[mediaformat]

I've adhered to the styleguide, but running codesniffer is on my todo list.

[benwerd]

🎉🎉 🎉 🎉

Reviewing now!

[benwerd]

LG with some suggestions to clearly scope AP methods in their names. THANK YOU!!

[mediaformat]

@benwerd Good to go!

[mediaformat]

Actually, I've just found a bunch of errors and warnings running the code sniffer.

A TOTAL OF 148 ERRORS WERE FIXED IN 35 FILES
PHPCBF FAILED TO FIX 18 FILES

Will fix these...

[mediaformat]

I can't seem to get phpunit working even after having done export KNOWN_DOMAIN='known.local'.

Otherwise good to go!

[mediaformat]

Ready to go

[benwerd]

LG!!!!! 👍