Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply phpcbf to all PHP #2900

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Apply phpcbf to all PHP #2900

merged 1 commit into from
Mar 4, 2021

Conversation

lindner
Copy link
Collaborator

@lindner lindner commented Feb 10, 2021

Here's what I fixed or added:

Ran phpcfbf on all files as per the instructions

Here's why I did it:

Checklist: ([x] to check/tick the boxes)

  • This pull request addresses a single issue
  • If this code includes interface changes, I've included screenshots in this Pull Request thread
  • I've adhered to Known's style guide (these codesniffer rules might help!)
  • My git branch is named in a descriptive way - i.e., yourname-summary-of-issue
  • I've tested my code in-browser
  • My code contains descriptive comments
  • I've added tests where applicable, and...
  • I can run the unit tests successfully.

@lindner
Copy link
Collaborator Author

lindner commented Mar 3, 2021

review?

Copy link
Member

@benwerd benwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@benwerd benwerd merged commit 32c1f1c into idno:dev Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants