[feat] Detect missing files in summary_database()
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2ea345 to
e96c7eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 99.81% 99.82%
=======================================
Files 5 5
Lines 1084 1146 +62
=======================================
+ Hits 1082 1144 +62
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
summary_database()did not inform incomplete coverage of years specified #40summary_database()can append results to the previous scan and detect if any previously matched NetCDF files do not exist. It stores the metadata of those missing files as a new attributenot_foundin the results. Warnings are issued ifwarningis set toTRUE. Also, a new parametermisshas been added to control how to manage those invalid entries. You can set it to"keep", which is the default, to do nothing about it or"overwrite"to overwrite those entries based on the newly matched NetCDF files if possible.