Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #25

Merged
merged 23 commits into from
Nov 22, 2021
Merged

Add tests #25

merged 23 commits into from
Nov 22, 2021

Conversation

hongyuanjia
Copy link
Member

@hongyuanjia hongyuanjia commented Nov 21, 2021

Pull request overview

  • Fixes Use GitHub Actions with cache to run full tests #21
  • Besides adding tests, some minor bugs have been fixed also:
    • Fix the error in summary_database() when no NetCDF files are found in the input directory.
    • Fix the error about overwriting temporary EPW file when epw in match_coord() is a search string.
    • Now morphing_epw() can correctly fall back to use "Shift" method when any missing values are detected in maximum and minimum prediction values of climate variables.
    • Fix the wrong warning messages when combined method is used in morphing_epw().

@hongyuanjia hongyuanjia self-assigned this Nov 21, 2021
@hongyuanjia hongyuanjia added the CI label Nov 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #25 (b628731) into master (86f058a) will increase coverage by 83.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
+ Coverage   16.47%   99.81%   +83.33%     
===========================================
  Files           6        5        -1     
  Lines        1129     1063       -66     
===========================================
+ Hits          186     1061      +875     
+ Misses        943        2      -941     
Impacted Files Coverage Δ
R/coord.R 100.00% <100.00%> (+100.00%) ⬆️
R/esgf.R 100.00% <100.00%> (+37.26%) ⬆️
R/morph.R 100.00% <100.00%> (+100.00%) ⬆️
R/netcdf.R 99.33% <100.00%> (+99.33%) ⬆️
R/utils.R 100.00% <100.00%> (+5.88%) ⬆️
R/epwshiftr-package.R
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f058a...b628731. Read the comment docs.

@hongyuanjia hongyuanjia merged commit e656b9a into master Nov 22, 2021
@hongyuanjia hongyuanjia deleted the coverage branch November 22, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GitHub Actions with cache to run full tests
2 participants