Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default mime type encode as json for amqp protocol #120

Merged
merged 4 commits into from
Feb 3, 2025
Merged

add default mime type encode as json for amqp protocol #120

merged 4 commits into from
Feb 3, 2025

Conversation

raghuramg
Copy link
Contributor

@raghuramg raghuramg commented Jan 16, 2025 •
edited
Loading

https://www.pivotaltracker.com/story/show/188793717

  • Set the DefaultMimeType for AMQP to application/json and ensure all AMQP payloads are encoded using the mime_encode operation.

  • Ensure the mime_decode operation gracefully returns the JSON payload without raising errors when the mime_type is set to application/zlib.

@raghuramg raghuramg force-pushed the default_json_encode branch from 00f2ac6 to 886792f Compare January 16, 2025 22:26
@raghuramg raghuramg force-pushed the default_json_encode branch from 886792f to 5ad8bba Compare January 17, 2025 15:50
@raghuramg raghuramg force-pushed the default_json_encode branch 4 times, most recently from 6f767e9 to 9d14d7e Compare January 17, 2025 16:31
@raghuramg raghuramg force-pushed the default_json_encode branch from 9d14d7e to 54703b3 Compare January 17, 2025 16:45
@raghuramg raghuramg changed the title add default mime type encode json add default mime type encode as json for amqp protocol Jan 17, 2025
@raghuramg raghuramg requested a review from saikumar9 January 17, 2025 18:41
@saikumar9 saikumar9 enabled auto-merge (squash) January 17, 2025 22:24
@saikumar9 saikumar9 self-requested a review January 17, 2025 22:25
saikumar9
saikumar9 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

saipraveen18
saipraveen18 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@saipraveen18 saipraveen18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@saikumar9 saikumar9 merged commit b396b0e into trunk Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saipraveen18 saipraveen18 saipraveen18 approved these changes

@saikumar9 saikumar9 saikumar9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raghuramg @saipraveen18 @saikumar9