Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test WriteZipStreamWithNoCompression Failed #423

Closed
workgroupengineering opened this issue Feb 12, 2020 · 3 comments
Closed

Test WriteZipStreamWithNoCompression Failed #423

workgroupengineering opened this issue Feb 12, 2020 · 3 comments

Comments

@workgroupengineering
Copy link

Steps to reproduce

  1. Run test

Expected behavior

testing must not fail

Actual behavior

Test throw "No entry matching source file "{0}" found in archive, found "{1}""

Version of SharpZipLib

cuurent SharpZipLib/master

Obtained from (only keep the relevant lines)

  • Compiled from source, commit: 803b4a2
  • Downloaded from GitHub
workgroupengineering added a commit to workgroupengineering/SharpZipLib.Net35 that referenced this issue Feb 12, 2020
@workgroupengineering
Fixed Issue icsharpcode#423
93d5854
@Numpsy
Copy link
Contributor

Numpsy commented Feb 17, 2020

Related to the discussion in #341 - I'm not sure whether the name transforming/cleaning should be done in ZipOutputStream, rather than always being left up to the caller.

@Numpsy Numpsy mentioned this issue Jul 13, 2020
Closed
@Numpsy
Copy link
Contributor

Numpsy commented Aug 8, 2020

should be fixed now?

@piksel
Copy link
Member

piksel commented Aug 9, 2020

Yeah, I moved this to it's own test in #502 and forgot to link this issue!

Since #497 the underlying cause should be fixed as well.

@piksel piksel closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piksel @Numpsy @workgroupengineering