Fix #3382: Support compiler-generated throw-helper invocations in switch-expression implicit default-case. #3404
+158
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch-expression implicit default-case.
1677b3b to
37f3d0b
Compare
siegfriedpammer
commented
Feb 21, 2025
| @@ -106,6 +106,7 @@ public static List<IILTransform> GetILTransforms() | |||
| new SwitchDetection(), | |||
| new SwitchOnStringTransform(), | |||
| new SwitchOnNullableTransform(), | |||
| new SwitchExpressionDefaultCaseTransform(), | |||
There was a problem hiding this comment.
I think that doing this as a post-processing transform of switch detection is a problem. At this point there is no separate block container for switch (BlockContainerKind.Switch is not yet set)... this transformation only happens later in LoopDetection. So this transform would have to perform all the validation that happens in the other switch detection transforms again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution