Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3025
Problem
Solution
Normally,
AddTypeAnnotation
is called right afterConvertTypeHelper
in theConvertType
method:ILSpy/ICSharpCode.Decompiler/CSharp/Syntax/TypeSystemAstBuilder.cs
Lines 244 to 245 in bf0d74d
But in the case of nested types,
ConvertTypeHelper
calls itself recursively for declaring types, and thereforeAddTypeAnnotation
was never called for these nodes.This is a very simple change.
I couldn't find any existing unit tests which check for type annotations (
ResolveResult
), so I wasn't sure where to put this. If you'd like me to add a unit test, please tell me in which way you'd like for type annotations to be tested.