Fix UsingTranform
for inlined isinst
variation (refs #2199)
#2841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers:
#2199
Problem
The file present in the issue contained a strange variation of a using statement with the
isinst
. I am unsure what compiler is responsible for this kind of IL. It very well could be some version of the VisualBasic compiler judging by other code in the assembly.An example of this can be found in
Class8.smethod_0()
.Before:
Solution
Added necessary logic to pattern match the additional
isinst
instructions.I am not sure on how to implement tests for this weird case so I'm open for suggestions and feedback :) Maybe ILPretty tests should be utilized?