Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decompile C++/CLI assemblies #2698

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

kant2002
Copy link
Contributor

When C++/CLI project produce assembly it generates target attribute like this

[assembly: TargetFramework(".NETCoreApp,Version=7.0", FrameworkDisplayName = "")]

when C# generates TargetFrameworkAttribute it produce slightly different format

[assembly: TargetFramework(".NETCoreApp,Version=v7.0", FrameworkDisplayName = "")]

Link to issue(s) this covers

Problem

Link to, or brief information about the issue

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
  • Which part of this PR is most in need of attention/improvement?
  • At least one test covering the code changed

When C++/CLI project produce assembly it generates target attribute like this
```
[assembly: TargetFramework(".NETCoreApp,Version=7.0", FrameworkDisplayName = "")]
```
when C# generates `TargetFrameworkAttribute` it produce slightly different format
```
[assembly: TargetFramework(".NETCoreApp,Version=v7.0", FrameworkDisplayName = "")]
```
@dgrunwald dgrunwald merged commit 93d97ab into icsharpcode:master Jun 2, 2022
@kant2002 kant2002 deleted the patch-1 branch June 2, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants