Fix displaying icons from embedded resources #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When BitmapCacheOption.None is used, icons will not be loaded from the stream until they are needed to be displayed. In this case, the icon loading will be triggered when the text box is rendered from the UI thread. However by that time the steam object will have already been disposed. This results in no icons being visibile. The fix is to eager load the icons while the stream is still alive. An alterntive fix would be to defer disposing the stream to a later time or not dispose it at all.
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
BitmapCacheOption.Noneis used, icons will not be loaded from thestream until they are needed to be displayed. In this case, the icon
loading will be triggered when the text box is rendered from the UI thread.
However by that time the steam object will have already been disposed.
This results in no icons being visible.
Solution
The fix is to eager load the icons while the stream is still alive.
An alternative fix would be to defer disposing the stream to a later time
or not dispose it at all.