-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use astbuilder for all integer literals #1322
Merged
siegfriedpammer
merged 10 commits into
master
from
use-astbuilder-for-all-integer-literals
Dec 10, 2018
Merged
Use astbuilder for all integer literals #1322
siegfriedpammer
merged 10 commits into
master
from
use-astbuilder-for-all-integer-literals
Dec 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ResolveResult to the parameter type.
This change still has some issues, a quick look at the roundtrip-diff showed:
|
…e-astbuilder-for-all-integer-literals
…hub.com/icsharpcode/ILSpy into use-astbuilder-for-all-integer-literals
No. 1 is fixed now. No. 2 affects literals/constants of all small integer types, it seems:
The left side is short and the right side should be implicitly convertible to short. The resolve result (5, System.Int16) is replaced by a different instance, but with the same values. Because of this, an explicit cast is added by ConvertTo. |
ElektroKill
pushed a commit
to dnSpyEx/ILSpy
that referenced
this pull request
Jul 12, 2021
…or-all-integer-literals Use astbuilder for all integer literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.