Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ignored native integer roundtrip tests #2541

Closed
siegfriedpammer opened this issue Nov 8, 2021 · 1 comment
Closed

Enable ignored native integer roundtrip tests #2541

siegfriedpammer opened this issue Nov 8, 2021 · 1 comment
Labels
Bug C# Decompiler The decompiler engine itself

Comments

@siegfriedpammer
Copy link
Member

Currently three of our conversions roundtrip tests are disabled:

  • ExplicitConversions_With_NativeInts
  • ExplicitConversions_32_With_NativeInts
  • Random_TestCase_1_With_NativeInts

We should fix the remaining issues and enable these tests.
@siegfriedpammer siegfriedpammer added Decompiler The decompiler engine itself C# Enhancement Areas for improvement Bug and removed Enhancement Areas for improvement labels Nov 8, 2021
@siegfriedpammer
Copy link
Member Author

Didn't you forget Random_TestCase_1_With_NativeInts?

ElektroKill added a commit to dnSpyEx/ILSpy that referenced this issue Jan 2, 2022
@ElektroKill
Fix icsharpcode#2541: Add explicit unchecked() around non-constant …
5e2de0f 
…cast of constant to `nint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug C# Decompiler The decompiler engine itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siegfriedpammer