Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hanging when decompiling #1429

Closed
terrylao opened this issue Feb 20, 2019 · 2 comments
Closed

Hanging when decompiling #1429

terrylao opened this issue Feb 20, 2019 · 2 comments

Comments

@terrylao
Copy link

TransCode.zip
as attachment,
when save code, it always show decompiling, over 10 minutes.
@siegfriedpammer
Copy link
Member

siegfriedpammer commented Feb 20, 2019 •
edited
Loading

This is caused by huge array initializers in CodeConvert..ctor:

  1. 41670 elements (Host2UTF_tbl)
  2. 65536 elements (EBCDIC_tbl)
  3. 65536 elements (BIG5_tbl)

These are expanded from RuntimeHelpers.InitializeArray, so not generating the initializer syntax is not possible. I think the main problem is the code that converts ILAst to C# code as detailed in #1202.

@siegfriedpammer
Copy link
Member

siegfriedpammer commented Feb 20, 2019 •
edited
Loading

Decompiling the CodeConvert class is now down to 14 seconds in debug build on my machine.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2020
ElektroKill pushed a commit to dnSpyEx/ILSpy that referenced this issue Jul 15, 2021
@siegfriedpammer @ElektroKill
Fix icsharpcode#1429: Optimize ExpressionBuilder.TranslateArrayInitia…
02b9a3d 
…lizer by applying optimizations suggested in icsharpcode#1202.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siegfriedpammer @terrylao