Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to get deployment hash and deployment result separately #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nightowl121
Copy link
Contributor

During the integration tests, we often require to deploy a large set of contracts. By default, while deploying contracts we need to wait blockTime * no. of contracts. This creates a synchronous delay in integration test.

This PR allows developer to deploy all contracts, get all hashes and then wait for a single block time which helps in asynchronous deployment.

nightowl121 and others added 4 commits February 14, 2023 14:45
Signed-off-by: Night Owl <nightowl121@protonmail.com>
Signed-off-by: Night Owl <nightowl121@protonmail.com>
…d result for deployment separately

Signed-off-by: Night Owl <nightowl121@protonmail.com>
@jspark-icon
Copy link
Member

DefaultScoreClient does not aim to support asynchronous.
To deploy asynchronously, you can use async support classes as below example.

var f1 = CompletableFuture.supplyAsync(() -> DefaultScoreClient.of(System.getProperties()));
var f2 = CompletableFuture.supplyAsync(() -> DefaultScoreClient.of(System.getProperties()));
var c1 = f1.get();
var c2 = f2.get();
//use c1, c2 codes

@jspark-icon jspark-icon reopened this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants