Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Refactor Atama #19

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

FaaizHaikal
Copy link
Contributor

@FaaizHaikal FaaizHaikal commented Apr 14, 2024

Jira Link:

Description

  • Fix head scanning functions and mode
  • Fix tracking object calculations
  • Disable updating the head data from the tachimawari current_joints, as this causes the robot's head to stutter when tracking object

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

data/head.json Outdated Show resolved Hide resolved
@FaaizHaikal FaaizHaikal merged commit f4ae94e into master Apr 29, 2024
1 check failed
@FaaizHaikal FaaizHaikal deleted the enhancement/refactor-atama branch April 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants