Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NuGet Audit build failure #4050

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix NuGet Audit build failure #4050

merged 2 commits into from
Sep 10, 2024

Conversation

pepone
Copy link
Member

@pepone pepone commented Sep 10, 2024

This PR fixes the NuGet Audit build failures on main.

@bernardnormier
Copy link
Member

I don't understand this fix.

rg Microsoft.Extensions.Logging.Console
IceRpc.Retry.Tests/IceRpc.Retry.Tests.csproj
14:    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.*" />

IceRpc.Tests.Common/IceRpc.Tests.Common.csproj
12:    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.*" />

IceRpc.Logger.Tests/IceRpc.Logger.Tests.csproj
14:    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.*" />
bernard@studio tests % 

As far I can tell, these two tests (Retry and Logger) need this Logging.Console assembly.

@pepone
Copy link
Member Author

pepone commented Sep 10, 2024

As far I can tell, these two tests (Retry and Logger) need this Logging.Console assembly.

These are pulled by IceRpc.Tests.Common which already has the workaround for JSON

Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a cleanup PR, to remove extra dependencies?

@pepone
Copy link
Member Author

pepone commented Sep 10, 2024

This is just a cleanup PR, to remove extra dependencies?

No, the build on main started to fail for logger and retry because of NuGet audit

@pepone pepone merged commit 4771d12 into icerpc:main Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants