Update build telemetry to use the local IceRpc packages #4040
+154
−159
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,4 +108,4 @@ | |
| "paths": ["examples/slice/Upload"] | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Copyright (c) ZeroC, Inc. | ||
|
|
||
| using Microsoft.Build.Framework; | ||
| using Microsoft.Build.Utilities; | ||
|
|
||
| namespace IceRpc.Protobuf.Tools; | ||
|
|
||
| /// <summary> | ||
| /// A MSBuild task that reports Protobuf build telemetry data to the IceRPC build telemetry service. | ||
| /// </summary> | ||
| public class BuildTelemetryTask : ToolTask | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the compilation hash. | ||
| /// </summary> | ||
| [Required] | ||
| public string CompilationHash { get; set; } = ""; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the number of source files in the Slice compilation. | ||
| /// </summary> | ||
| public int SourceFileCount { get; set; } | ||
|
Comment on lines
+19
to
+22
There was a problem hiding this comment. This should say |
||
|
|
||
| /// <summary> | ||
| /// Gets or sets the working directory. | ||
| /// </summary> | ||
| [Required] | ||
| public string WorkingDirectory { get; set; } = ""; | ||
|
|
||
| /// <inheritdoc/> | ||
| protected override string ToolName => "dotnet"; | ||
|
|
||
| /// <inheritdoc/> | ||
| protected override string GetWorkingDirectory() => WorkingDirectory; | ||
|
|
||
| /// <inheritdoc/> | ||
| protected override string GenerateFullPathToTool() => ToolName; | ||
|
|
||
| /// <inheritdoc/> | ||
| protected override string GenerateCommandLineCommands() | ||
| { | ||
| var commandLine = new CommandLineBuilder(); | ||
| commandLine.AppendFileNameIfNotNull("IceRpc.BuildTelemetry.Reporter.dll"); | ||
| commandLine.AppendSwitch("--hash"); | ||
| commandLine.AppendSwitch(CompilationHash); | ||
| commandLine.AppendSwitch("--idl"); | ||
| commandLine.AppendSwitch("protobuf"); | ||
| commandLine.AppendSwitch("--src-file-count"); | ||
| commandLine.AppendSwitch(SourceFileCount.ToString()); | ||
| return commandLine.ToString(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Overriding this method to suppress any warnings or errors. | ||
| /// </summary> | ||
| protected override void LogEventsFromTextOutput(string singleLine, MessageImportance messageImportance) { } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworked the code to use the generated constructor, and remove the other constructor that hardcodes the defaults